----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123381/#review79045 -----------------------------------------------------------
I think we should always pulse, and if available, use the needs attention icon (but don't cycle between normal and attention icon) - Kai Uwe Broulik On April 16, 2015, 11:23 vorm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123381/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 11:23 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This returns the kde4 behavior of simply switching the icon for attention > icon when animations are disabled. > > I don't think that always using the attention icon with the pulse animation > looks good, it looks like there's too much going on. I believe it should be > an either-or. So I did it only as a fallback. > > > Diffs > ----- > > applets/systemtray/package/contents/ui/StatusNotifierItem.qml 5380b09 > applets/systemtray/package/contents/ui/TaskDelegate.qml f2738bd > > Diff: https://git.reviewboard.kde.org/r/123381/diff/ > > > Testing > ------- > > I didn't test with animations off (I'm not sure how to set) so I just > explicitly enabled the timer and disabled the PulseAnimation. Works just like > in the old times. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
