Re: Review Request 122505: Warn about brightness getting too low

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/#review75824 --- Basic rule from design for safety: Don't use a warning if you

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On feb 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated a

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 10, 2015, 7:51 p.m., Xuetian Weng wrote: > > kcms/dateandtime/main.cpp, line 146 > > > > > > This part can be async. > > > > You can do it by chain two different callback if it need to be done

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 10, 2015, 7:51 p.m., Xuetian Weng wrote: > > kcms/dateandtime/main.cpp, line 146 > > > > > > This part can be async. > > > > You can do it by chain two different callback if it need to be done

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 10, 2015, 7:51 p.m., Xuetian Weng wrote: > > kcms/dateandtime/main.cpp, line 146 > > > > > > This part can be async. > > > > You can do it by chain two different callback if it need to be done

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review75801 --- kcms/dateandtime/main.cpp

Re: Get panel list and hidding them via C++ module

On Tuesday 10 February 2015 12:32:49 Sebastian Kügler wrote: > Why not just add the ability to hide a panel with a shortcut? Just an idea that some related items may be collected by one item (e.g. Plasmoid) to prevent similar actions to configure item. (BTW I didn't find ability to hide panel by

[Powerdevil] [Bug 189456] powerdevil should not suspend when computer is being shutdown

https://bugs.kde.org/show_bug.cgi?id=189456 Kai Uwe Broulik changed: What|Removed |Added Version Fixed In||5.3.0 Status|REOPENED

Re: Review Request 122513: Avoid comparing unintialised variable if BREEZE_HAVE_KSTYLE is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122513/ --- (Updated Feb. 10, 2015, 4:48 p.m.) Status -- This change has been ma

Re: Review Request 122513: Avoid comparing unintialised variable if BREEZE_HAVE_KSTYLE is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122513/#review75799 --- Ship it! Nice spotting ! Thanks ! - Hugo Pereira Da Costa

Review Request 122513: Avoid comparing unintialised variable if BREEZE_HAVE_KSTYLE is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122513/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

Re: Review Request 122512: [screenlocker] Add a KKeySequenceWidget to configuration interface

> On Feb. 10, 2015, 4:10 p.m., Bhushan Shah wrote: > > ksmserver/screenlocker/kcm/kcm.cpp, lines 96-97 > > > > > > isn't ksmserver doing this already? I looked at kwin configuration modules for how it's handled a

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 9, 2015, 7:47 a.m., Martin Gräßlin wrote: > > kcms/dateandtime/main.cpp, line 57 > > > > > > does it need to be a blocking dbus call? Any chance in getting it use a > > watcher? It's tricky as load() i

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 10, 2015, 3:55 p.m.) Review request for Plasma. Repositor

Re: Review Request 122512: [screenlocker] Add a KKeySequenceWidget to configuration interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122512/#review75795 --- File Attachment: KCM with new item - missing-tasks-applet1.pn

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/ --- (Updated Feb. 10, 2015, 3:04 p.m.) Status -- This change has been ma

Review Request 122512: [screenlocker] Add a KKeySequenceWidget to configuration interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122512/ --- Review request for Plasma. Bugs: 325622 https://bugs.kde.org/show_bug

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

> On Feb. 10, 2015, 1:33 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 161 > > > > > > Make sure you test this actually gets called when you switch VTs. > > > > It

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/#review75791 --- Ship it! Ship It! - David Edmundson On Feb. 10, 2015, 1:19

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

> On Feb. 10, 2015, 2:33 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 161 > > > > > > Make sure you test this actually gets called when you switch VTs. > > > > It

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

> On Feb. 10, 2015, 1:29 p.m., David Edmundson wrote: > > I'm not convinced this is right. > > > > From the doc you linked: > > This is necessary for the system to implement auto-suspend when all > > sessions are idle. > > > > When we lock the screen, powerdevil is still running, no? > > >

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

> On Feb. 10, 2015, 1:33 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 161 > > > > > > Make sure you test this actually gets called when you switch VTs. > > > > It

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

> On Feb. 10, 2015, 2:33 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 161 > > > > > > Make sure you test this actually gets called when you switch VTs. > > > > It

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

> On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote: > > I'm not convinced this is right. > > > > From the doc you linked: > > This is necessary for the system to implement auto-suspend when all > > sessions are idle. > > > > When we lock the screen, powerdevil is still running, no? > > >

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/#review75785 --- FWIW, I think that's a good idea. As David says, make sure to

Change in plasma-framework[master]: Unify when tooltips are shown and kept alive.

David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/365 Change subject: Unify when tooltips are shown and kept alive. .. Unify when tooltips are shown and kept alive. A new tooltip would

Re: Review Request 122500: Don't delete widgets directly when changing styles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/ --- (Updated Feb. 10, 2015, 1:47 p.m.) Status -- This change has been ma

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 10, 2015, 1:43 p.m.) Status -- This change has been ma

Re: Review Request 122500: Don't delete widgets directly when changing styles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/#review75782 --- Ship it! Ship It! - Hugo Pereira Da Costa On Feb. 10, 2015

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75781 --- Ship it! Ship It! - Marco Martin On Feb. 10, 2015, 1:35 p.

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75780 --- +1 - David Edmundson On Feb. 10, 2015, 1:35 p.m., Vishesh H

Re: Review Request 122500: Don't delete widgets directly when changing styles

> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote: > > Although I have no objection against the change, I must admit I don't > > understand what's wrong with the current code, nor the actual description > > of the patch. > > "registerWidget may take an existing widget as a parameter. I

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 10, 2015, 1:35 p.m.) Review request for Plasma. Changes -

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/#review75778 --- Ship it! lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/#review75777 --- I'm not convinced this is right. >From the doc you linked:

Re: Review Request 122500: Don't delete widgets directly when changing styles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/ --- (Updated Feb. 10, 2015, 1:25 p.m.) Review request for Plasma and Hugo Per

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/ --- (Updated Feb. 10, 2015, 2:21 p.m.) Review request for Plasma. Changes -

Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/ --- Review request for Plasma. Bugs: 326633 https://bugs.kde.org/show_bug

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/#review75776 --- ksmserver/screenlocker/logind.cpp

Re: Review Request 122509: [screenlocker] Perform KAuthorized check for org.freedesktop.ScreenSaver.Lock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122509/ --- (Updated Feb. 10, 2015, 12:35 p.m.) Status -- This change has been m

Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122510/ --- Review request for Plasma. Bugs: 271731 https://bugs.kde.org/show_bug

Re: Get panel list and hidding them via C++ module

On Monday, February 09, 2015 22:47:20 Evgeniy Alekseev wrote: > > Have you looked at desktop scripting to achieve what you are looking for? > > There is an applet on which I'm working now (rather, on porting) which > provides some concepts from minimalistic WMs (predominantly tiling ones) > which

Re: Proposal regarding plasmate's release

On Tuesday, February 03, 2015 12:29:08 Philipp A. wrote: > Sebastian Kügler schrieb am Tue Feb 03 2015 at 12:59:22: > > If you're using imports, you have to install them first, no way around > > that. > > no way, that’s silly. > > how can we fix that? You may be able to work around that by adju

[plasma-mediacenter] browsingbackends: Merge branch 'bshah/pmc2'

Git commit 5fcea4fd58b6799c785958cd6f1455c3865e1165 by Bhushan Shah. Committed on 10/02/2015 at 12:20. Pushed by bshah into branch 'master'. Merge branch 'bshah/pmc2' This merges the new design in master branch, Few things - free from kdelibs4support - requires clean rebuild and install dir - fi

Re: Review Request 122509: [screenlocker] Perform KAuthorized check for org.freedesktop.ScreenSaver.Lock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122509/#review75774 --- Ship it! Ship It! - David Edmundson On Feb. 10, 2015, 10:5

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote: > > Although I have no objection against the change, I must admit I don't > > understand what's wrong with the current code, nor the actual description > > of the patch. > > "registerWidget may take an existing widget as a parameter. I

Re: Review Request 122508: [screenlocker] Support global shortcut for changing keyboard layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122508/ --- (Updated Feb. 10, 2015, 12:06 p.m.) Status -- This change has been m

Re: Review Request 122508: [screenlocker] Support global shortcut for changing keyboard layout

> On Feb. 10, 2015, 12:23 p.m., David Edmundson wrote: > > Did the little indicator in the main UI change? just tested: yes - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12250

Re: Review Request 122509: [screenlocker] Perform KAuthorized check for org.freedesktop.ScreenSaver.Lock

> On Feb. 10, 2015, 12:35 p.m., David Edmundson wrote: > > If an admin as root says to lock the screen via logind, should it not lock > > regarless? > > > > (I don't know the right answer, just raising a question) > If an admin as root says to lock the screen via logind, should it not lock >

Re: Review Request 122509: [screenlocker] Perform KAuthorized check for org.freedesktop.ScreenSaver.Lock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122509/#review75768 --- If an admin as root says to lock the screen via logind, should

Re: Review Request 122508: [screenlocker] Support global shortcut for changing keyboard layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122508/#review75767 --- Ship it! Did the little indicator in the main UI change? - D

Review Request 122509: [screenlocker] Perform KAuthorized check for org.freedesktop.ScreenSaver.Lock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122509/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- (Updated Feb. 10, 2015, 10:07 a.m.) Status -- This change has been m

Jenkins build is back to normal : plasma-workspace_master_qt5 #1292

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review75763 --- Ship it! A few minor nitpicks. Nice work! We can fix and make

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated

Review Request 122508: [screenlocker] Support global shortcut for changing keyboard layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122508/ --- Review request for Plasma. Bugs: 331726 https://bugs.kde.org/show_bug

Build failed in Jenkins: plasma-workspace_master_qt5 #1291

See Changes: [mklapetek] Sanitize whitespace in notification popups [shafff] fix total system freeze on some systems like my 10 inch netbook [lukas] set the right widget theme [scripty] SVN_SILENT made messages (.desktop file)

Re: Review Request 122505: Warn about brightness getting too low

> On feb 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated a

Re: Review Request 122505: Warn about brightness getting too low

> On Feb. 10, 2015, 9:01 vorm., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). As I stated above, "all the way down" can me

Re: Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122506/#review75759 --- shell/shellcorona.cpp

Re: Review Request 122339: Add KWorkSpace::isShuttingDown()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/ --- (Updated Feb. 10, 2015, 9:15 a.m.) Status -- This change has been ma

Re: Review Request 122505: Warn about brightness getting too low

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/#review75756 --- I'm not quite sure if a user wants to see a warning message at

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #12 from Antonis G. --- (In reply to Kai Uwe Broulik from comment #11) > The threads complaining about the OSD you have linked do not apply to the > Plasma 5 world. In Plasma 4.x the OSD would show up whenever the brightness > changed, for w