> On Feb. 10, 2015, 7:51 p.m., Xuetian Weng wrote: > > kcms/dateandtime/main.cpp, line 146 > > <https://git.reviewboard.kde.org/r/122400/diff/5/?file=348191#file348191line146> > > > > This part can be async. > > > > You can do it by chain two different callback if it need to be done one > > after another. Lambda would be helpful in this case to keep code short.
I wrote on line 137 why I did this... but given lots of people keep commenting, but I'll change it and the legacy version too Note that on line 195 we block the entire UI for 5 seconds anyway, so changing this isn't going to have any noticable impact given that problem exists. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review75801 ----------------------------------------------------------- On Feb. 10, 2015, 3:55 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122400/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 3:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The current time setting helper is incredibly broken. > > It manually tries to run a range of NTP utilities, all of which are > deprecated. > > We can just call timedated directly and cut out the middleman as it has > uses polkit anyway. > > This is currently an optional dependency, and the original helper still > exists. It makes the code messy, but we have users to support for now. > > Finding timedated is an cmake option rather than querying for systemd > libs to make it easier for those deploying shims, such as BSD. > > > (code is in two commits, first abstracting the saving from the dtime class; > then adding in the second save mechanism) > > > Diffs > ----- > > kcms/dateandtime/CMakeLists.txt 4a987ae > kcms/dateandtime/dateandtime.ui c073b5e > kcms/dateandtime/dtime.h 1a90698 > kcms/dateandtime/dtime.cpp 482e483 > kcms/dateandtime/main.h c1e5234 > kcms/dateandtime/main.cpp 0041a9d > kcms/dateandtime/timedated1.xml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122400/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
