----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/#review75824 -----------------------------------------------------------
Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures recoverability. Don't display any warning. Instead, when the slider reaches the minimum, display a hint saying "To prevent switching off the screen by accident, setting the brightness lower than [sensible value]% is only possible using the keyboard". That way, it's not possible to maneuver yourself in an unrecoverable position but people who like to switch off their screen backlight can still do so using the keyboard. And we don't need to show a scary warning, but a helpful hint instead. - Thomas Pfeiffer On Feb. 9, 2015, 10:25 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122505/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 10:25 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > Some graphics drivers, notably Intel, turn off the backlight completely when > brightness reached zero, which is also in the spec (0 = off, 1 = very dim) > but imho that's unexpected. To prevent the user from accidentally turnign the > screen off, especially when keyboard brightness controls don't work, which > sadly still happens quite often, the slider breaks free from the user's drag > (by becoming disable for two (perhaps 1 is enough?) seconds, so we also catch > the mouse wheel case) and displays a warning (which stays there until screen > brightness is dialed up again). > > > Diffs > ----- > > applets/batterymonitor/package/contents/ui/BrightnessItem.qml 546ab58 > applets/batterymonitor/package/contents/ui/PopupDialog.qml a2acf31 > > Diff: https://git.reviewboard.kde.org/r/122505/diff/ > > > Testing > ------- > > Works pretty well, I just realized I forgot the mousewheel-on-trayicon case. > Also, I'm open to wording suggestions since it sounds more like "we suck, > sorry about that". (Note in the screenshot I used the mouse wheel, hence the > displayed 4% rather than 5) > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/8b585088-e33e-4862-9c46-207d06f566f1__dimwarning.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
