----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122513/#review75799 -----------------------------------------------------------
Ship it! Nice spotting ! Thanks ! - Hugo Pereira Da Costa On Feb. 10, 2015, 4:22 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122513/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 4:22 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > Avoid comparing unintialised variable if BREEZE_HAVE_KSTYLE is not set > > if BREEZE_HAVE_KSTYLE is not set CE_CapacityBar remains uninitialised > (random value). It should therefore not be used in any comparisons. > > For KDE4, BREEZE_HAVE_KSTYLE will always be false regardless so that > behaviour remains the same > > > Diffs > ----- > > kstyle/breezestyle.cpp 6d18300 > > Diff: https://git.reviewboard.kde.org/r/122513/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
