----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/#review75756 -----------------------------------------------------------
I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). - Mark Gaiser On feb 9, 2015, 10:25 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122505/ > ----------------------------------------------------------- > > (Updated feb 9, 2015, 10:25 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > Some graphics drivers, notably Intel, turn off the backlight completely when > brightness reached zero, which is also in the spec (0 = off, 1 = very dim) > but imho that's unexpected. To prevent the user from accidentally turnign the > screen off, especially when keyboard brightness controls don't work, which > sadly still happens quite often, the slider breaks free from the user's drag > (by becoming disable for two (perhaps 1 is enough?) seconds, so we also catch > the mouse wheel case) and displays a warning (which stays there until screen > brightness is dialed up again). > > > Diffs > ----- > > applets/batterymonitor/package/contents/ui/BrightnessItem.qml 546ab58 > applets/batterymonitor/package/contents/ui/PopupDialog.qml a2acf31 > > Diff: https://git.reviewboard.kde.org/r/122505/diff/ > > > Testing > ------- > > Works pretty well, I just realized I forgot the mousewheel-on-trayicon case. > Also, I'm open to wording suggestions since it sounds more like "we suck, > sorry about that". (Note in the screenshot I used the mouse wheel, hence the > displayed 4% rather than 5) > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/8b585088-e33e-4862-9c46-207d06f566f1__dimwarning.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
