Re: Review Request 121411: Don't trigger animation if size changed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- (Updated Dec. 11, 2014, 3:55 a.m.) Review request for KDE Frameworks, Pla

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Change in plasma-framework[master]: Use a shared config in tooltip

David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/216 Change subject: Use a shared config in tooltip .. Use a shared config in tooltip Change-Id: I68521f9066114a265c3f3444332e5e67016207

Change in plasma-framework[master]: Reparse settings when they change

David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/217 Change subject: Reparse settings when they change .. Reparse settings when they change Change-Id: Ibb13077943330417fa08d23ce1ea60f2

Change in plasma-framework[master]: Save SVGs only when a theme is unloaded, not on each theme p...

David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/215 Change subject: Save SVGs only when a theme is unloaded, not on each theme proxy .. Save SVGs only when a theme is unloaded, not on

Change in plasma-framework[master]: Do not keep reparsing plasmarc configuration

David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/214 Change subject: Do not keep reparsing plasmarc configuration .. Do not keep reparsing plasmarc configuration KConfig->reparseConfig

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 11:22 p.m.) Review request for Plasma and David E

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

https://bugs.kde.org/show_bug.cgi?id=341762 David Edmundson changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71751 --- kcms/access/kaccess.h

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 9:31 p.m.) Review request for Plasma and David Ed

[Breeze] [Bug 341762] New: When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

https://bugs.kde.org/show_bug.cgi?id=341762 Bug ID: 341762 Summary: When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup. Product: Breeze Version: unspecified Platform: openSUSE RPMs O

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71738 --- kcms/access/kaccess.cpp

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71739 --- kcms/access/kaccess.cpp

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dec. 10, 2014, 6:12 p.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 307 > > > > > > Found one of the reasons for the blurring. > > > > To some extent, your first patc

Change in plasma-framework[master]: roundToIconSize(0) should return 0

David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/213 Change subject: roundToIconSize(0) should return 0 .. roundToIconSize(0) should return 0 If an invalid icon size is passed to round

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review71735 --- src/declarativeimports/core/iconitem.cpp

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 6:11 p.m.) Review request for Plasma and David Ed

Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 6:10 p.m.) Review request for Plasma and David Ed

Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support

> On Dec. 10, 2014, 1:50 p.m., Lukáš Tinkl wrote: > > Did you test the accessibility features? Yes, they work fine. - Toby --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review7

Re: Review Request 120970: Remove combo "Graphical Effects"

> On Dec. 10, 2014, 3:19 p.m., Lukáš Tinkl wrote: > > I think this change has to be reverted, the setting in question is being > > used in frameworkintegration to set the level of graphical details to Qt, > > thru the QPA plugin: > > > > m_hints[QPlatformTheme::UiEffects] = cg.readEntry("Graph

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Qt 5.4

On Wednesday 10 December 2014 15:58:25 Jonathan Riddell wrote: > Qt 5.4 is out and it's time to make a decision on whether Plasma 5.2 will > require it. > > Speaking to packagers from Ubuntu, opensuse and Fedora they all have RC > packages and don't expect it to be difficult to have final packages

Re: Qt 5.4

On 12/10/2014 04:14 PM, Aleix Pol wrote: On Wed, Dec 10, 2014 at 4:10 PM, Eike Hein mailto:h...@kde.org>> wrote: There's a bunch of unsolved new regressions (e.g. DND of files is broken on 5.4) but nothing out of the ordinary breakage level I guess. Cheers, Eike I wasn

Re: Review Request 120970: Remove combo "Graphical Effects"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120970/#review71713 --- I think this change has to be reverted, the setting in questio

Re: Qt 5.4

On Wed, Dec 10, 2014 at 4:10 PM, Eike Hein wrote: > > There's a bunch of unsolved new regressions (e.g. DND of files is > broken on 5.4) but nothing out of the ordinary breakage level I > guess. > > > Cheers, > Eike I wasn't aware, I've worked on that code, if you can provide a test case I'll g

Re: Qt 5.4

There's a bunch of unsolved new regressions (e.g. DND of files is broken on 5.4) but nothing out of the ordinary breakage level I guess. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt 5.4

On Wed, Dec 10, 2014 at 3:58 PM, Jonathan Riddell wrote: > Qt 5.4 is out and it's time to make a decision on whether Plasma 5.2 will > require it. > > Speaking to packagers from Ubuntu, opensuse and Fedora they all have RC > packages and don't expect it to be difficult to have final packages. > >

Re: Qt 5.4

On Wednesday, December 10, 2014 15:58:25 Jonathan Riddell wrote: > Qt 5.4 is out and it's time to make a decision on whether Plasma 5.2 will > require it. > > Speaking to packagers from Ubuntu, opensuse and Fedora they all have RC > packages and don't expect it to be difficult to have final packag

Qt 5.4

Qt 5.4 is out and it's time to make a decision on whether Plasma 5.2 will require it. Speaking to packagers from Ubuntu, opensuse and Fedora they all have RC packages and don't expect it to be difficult to have final packages. I know there's a patch Martin says is needed but that shouldn't be har

Re: Review Request 121421: Make the OSD timeout a bit shorter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121421/ --- (Updated Dec. 10, 2014, 2:55 p.m.) Status -- This change has been ma

Re: Review Request 120970: Remove combo "Graphical Effects"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120970/ --- (Updated Dec. 10, 2014, 2:49 p.m.) Status -- This change has been ma

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- (Updated Dec. 10, 2014, 2:47 p.m.) Review request for Plasma. Repositor

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dec. 8, 2014, 11:20 p.m., Aleix Pol Gonzalez wrote: > > +1 > > > > Looks good to me > > Kai Uwe Broulik wrote: > I now experience a lot of situtations where icons start blurry and fade > to their full size again, like when opening systray for the first time or > locking the session w

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121421: Make the OSD timeout a bit shorter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121421/#review71705 --- Ship it! Given the old value was chosen rather randomly, this

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71700 --- Did you test the accessibility features? - Lukáš Tinkl On P

Re: Review Request 121424: Porting Accessibility Config Module away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 10, 2014, 1:44 p.m.) Review request for Plasma and David Ed

Re: Minutes Monday Plasma Hangout

On Tuesday 09 December 2014 12:58:19 Sebastian Kügler wrote: > Martin: > - Will check if the fix for context menues is in 5.4.0 just checked: the problematic commit is in 5.4 branch but *not* in 5.4.0 tag. Cheers Martin signature.asc Description: This is a digitally signed message part.

Re: Review Request 121421: Make the OSD timeout a bit shorter

> On Dec. 9, 2014, 11:56 p.m., Kai Uwe Broulik wrote: > > +1 > > > > 1000ms is too short > > 1500ms feels weird, it's *tick*, wait, …… ad OCD. > > 2500ms is just too long, especially with this huge (almost) opaque box of > > an OSD. > > Aleix Pol Gonzalez wrote: > I don't really have a

Re: Review Request 121421: Make the OSD timeout a bit shorter

> On Dec. 9, 2014, 10:56 p.m., Kai Uwe Broulik wrote: > > +1 > > > > 1000ms is too short > > 1500ms feels weird, it's *tick*, wait, …… ad OCD. > > 2500ms is just too long, especially with this huge (almost) opaque box of > > an OSD. > > Aleix Pol Gonzalez wrote: > I don't really have a

Re: New framework to review: KPackage

On Wednesday 10 December 2014, Albert Astals Cid wrote: > > I would like to submit it (kpackage repo) for the usual 2 weeks period of > > review. > > Add const & > void setDefaultMimeTypes(QStringList mimeTypes); > void setMimeTypes(const char *key, QStringList mimeTypes); > > You probabl

Re: Review Request 121421: Make the OSD timeout a bit shorter

> On Dec. 9, 2014, 11:56 p.m., Kai Uwe Broulik wrote: > > +1 > > > > 1000ms is too short > > 1500ms feels weird, it's *tick*, wait, …… ad OCD. > > 2500ms is just too long, especially with this huge (almost) opaque box of > > an OSD. > > Aleix Pol Gonzalez wrote: > I don't really have a

Re: Review Request 121365: Update brightness availability at runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121365/ --- (Updated Dec. 10, 2014, 9:40 a.m.) Status -- This change has been ma

Re: Review Request 121419: Improve Capslock Enabled warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/ --- (Updated Dec. 10, 2014, 9:40 a.m.) Status -- This change has been ma