----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71739 -----------------------------------------------------------
kcms/access/kaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50022> this isn't a complete port of KUniqueApplication There should be something with KDBusService in here. kcms/access/kaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50018> delete this bit of code. kcms/access/kaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50019> all the way to here. kcms/access/kaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50020> it should be safe to just delete this line. It will default to this. kcms/access/kaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50021> and this. - David Edmundson On Dec. 10, 2014, 6:11 p.m., Toby Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121424/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 6:11 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-desktop > > > Description > ------- > > [GCI2014]Remove the depencence on KDELibs4Support form KCMAccess > > > Diffs > ----- > > kcms/access/kaccess.h 716bfcf > kcms/access/kaccess.cpp aea6f86 > kcms/access/kcmaccess.h d3cb40f > kcms/access/kcmaccess.cpp 6c8bc65 > kcms/access/main.cpp 09864fc > kcms/access/CMakeLists.txt 64b1cc9 > > Diff: https://git.reviewboard.kde.org/r/121424/diff/ > > > Testing > ------- > > I have ran kcmshell5 kcmaccess, did see no problem. > > > Thanks, > > Toby Chen > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
