> On Dec. 10, 2014, 3:19 p.m., Lukáš Tinkl wrote:
> > I think this change has to be reverted, the setting in question is being
> > used in frameworkintegration to set the level of graphical details to Qt,
> > thru the QPA plugin:
> >
> > m_hints[QPlatformTheme::UiEffects] = cg.readEntry("GraphicEffectsLevel", 0)
> > != 0 ? QPlatformTheme::GeneralUiEffect : 0;
That's using it purely as a boolean. I'm not having a 5 entry combo box for
that.
Personally I say it can be a hidden config option; we don't /need/ to expose
every option just because it can be set.
If you really want it, I could combine it with Breeze's internal "Enable
Animation" config option. From a usability POV it seems better than having two
very similar sounding options which are scattered.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review71713
-----------------------------------------------------------
On Dec. 10, 2014, 2:49 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 2:49 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Remove combo "Graphical Effects"
>
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
>
>
> Diffs
> -----
>
> kcms/style/finetuning.ui 3abb692
> kcms/style/kcmstyle.cpp 6585ee6
>
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
