> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when user resize the UI or changes the settings. > 2. the animation IMHO is for smooth transition between different > icons/different icon effect (check volume icon, media player play/pause, > hovering with opacity changes), I don't see we need to have animated > transition from a scaled icon to the actual correct size icon.
Icon size changes may be infrequent but they do happen. It's important that when we resize the panel we don't re-render a tonne of SVGs constantly, we need resizing applets to be smooth. I don't understand where this blurriness is coming from; that implies we're loading it at a wrong size then resizing; if that's the case, lets fix that rather than hide it. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71665 ----------------------------------------------------------- On Dec. 9, 2014, 4:43 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121411/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 4:43 p.m.) > > > Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Kai Uwe > Broulik. > > > Repository: plasma-framework > > > Description > ------- > > Making transition between two different size doesn't make much sense, since > repainting is usually happens at that time and it could take some time to > finish. And animation need to be stopped if m_animValue is set manually. > > > Diffs > ----- > > src/declarativeimports/core/iconitem.cpp > ed3bb978f01cca98315fd425778139e4b9eeb64f > > Diff: https://git.reviewboard.kde.org/r/121411/diff/ > > > Testing > ------- > > Looks fine on tray icon and lock screen, no blurry transition anymore. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
