----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review71735 -----------------------------------------------------------
src/declarativeimports/core/iconitem.cpp <https://git.reviewboard.kde.org/r/121219/#comment50013> Found one of the reasons for the blurring. To some extent, your first patch was right before I told you to change it (sorry!) when the input size is 0,0 Units::roundToIconSize(0,0) returns 8. size is now not <= 0 so we load something. This means we'll animate when it gets a valid size. IMHO roundToIconSize should return 0 in this special case, as right now we have an entire code path that will never be used. I don't know if that will cause other problems. We never hit this before, because setSource() has a size check, but we now call loadPixmap directly in componentComplete() - David Edmundson On Dec. 5, 2014, 9:20 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121219/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:20 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This makes the IconItem load the icon immediately after component creation > and not wait 150ms there for no reason which prevents eg. flickering in the > OSD when it shows up. > > > Diffs > ----- > > src/declarativeimports/core/iconitem.h 8aecd17 > src/declarativeimports/core/iconitem.cpp ed3bb97 > > Diff: https://git.reviewboard.kde.org/r/121219/diff/ > > > Testing > ------- > > Totally forgot about that, just took it for granted that the OSD wouldn't > flicker anymore. > Resizing applets still has it scale the texture before re-rendering it. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
