Re: Review Request 117309: Fix build without X11

2014-04-01 Thread Martin Gräßlin
> On April 2, 2014, 2:47 a.m., Aleix Pol Gonzalez wrote: > > If it wasn't found, it should be false. Why's that wrong? > > Michael Palimaka wrote: > The way it currently evaluates, if X11 is not found, config-ksysguard.h > contains "#define HAVE_X11". This is then substituted resulting in l

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/ --- (Updated April 2, 2014, 8:29 a.m.) Status -- This change has been di

Review Request 117321: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117321/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

[KDE Bugtracking System] REMINDER: current Plasma regressions

2014-04-01 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 301424: https://bugs.kde.org/show_bug.cgi?id=301424 Priority: NOR Severity: normal Platform: openSUS

Re: Review Request 117310: Improve tests

2014-04-01 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117310/ --- (Updated April 2, 2014, 6 a.m.) Status -- This change has been marke

Re: Review Request 117310: Improve tests

2014-04-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117310/#review54836 --- This review has been submitted with commit f8daccca205ea493df

Re: Review Request 117309: Fix build without X11

2014-04-01 Thread Michael Palimaka
> On April 2, 2014, 12:47 a.m., Aleix Pol Gonzalez wrote: > > If it wasn't found, it should be false. Why's that wrong? The way it currently evaluates, if X11 is not found, config-ksysguard.h contains "#define HAVE_X11". This is then substituted resulting in literal "#if ", which fails to buil

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
> On April 1, 2014, 10:31 a.m., Kai Uwe Broulik wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 47 > > > > > > Imho it should be possible

Re: Review Request 117310: Improve tests

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117310/#review54832 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 6

Re: Review Request 117309: Fix build without X11

2014-04-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117309/#review54831 --- If it wasn't found, it should be false. Why's that wrong? - A

Review Request 117312: Disable PackageKit integration

2014-04-01 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117312/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: [kde-promo] Plasma Next Alpha release notes

2014-04-01 Thread Mark Gaiser
On Tue, Apr 1, 2014 at 9:32 PM, Marco Martin wrote: > On Tuesday 01 April 2014, Mark Gaiser wrote: >> Also, for a video of the alpha. I really think that it should be >> recorded again with - at the very least - the content of buttons >> aligned properly. Right now the buttons (in that video) have

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2014-04-01 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117041/ --- (Updated April 1, 2014, 8:05 p.m.) Review request for Plasma, Aleix Pol G

Re: [kde-promo] Plasma Next Alpha release notes

2014-04-01 Thread Marco Martin
On Tuesday 01 April 2014, Mark Gaiser wrote: > Also, for a video of the alpha. I really think that it should be > recorded again with - at the very least - the content of buttons > aligned properly. Right now the buttons (in that video) have a weird > text alignment. at what second? the wallpaper

Re: [kde-promo] Plasma Next Alpha release notes

2014-04-01 Thread Mark Gaiser
On Tue, Apr 1, 2014 at 8:18 PM, Jos Poortvliet wrote: > On Tuesday 01 April 2014 13:10:42 Martin Klapetek wrote: >> On Tue, Apr 1, 2014 at 1:04 PM, Martin Klapetek >> >> wrote: >> > Plus the idea with "by KDE" was to be only this additional touch, it >> > shouldn't really be mentioned/used as the

Re: [kde-promo] Plasma Next Alpha release notes

2014-04-01 Thread Jos Poortvliet
On Tuesday 01 April 2014 13:10:42 Martin Klapetek wrote: > On Tue, Apr 1, 2014 at 1:04 PM, Martin Klapetek > > wrote: > > Plus the idea with "by KDE" was to be only this additional touch, it > > shouldn't really be mentioned/used as the "new name", so I'd rather > > change > > the name as "Plasma

Review Request 117309: Fix build without X11

2014-04-01 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117309/ --- Review request for Plasma. Repository: libksysguard Description ---

Review Request 117310: Improve tests

2014-04-01 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117310/ --- Review request for Plasma. Repository: libksysguard Description ---

kde-workspace has been split (for frameworks)

2014-04-01 Thread Àlex Fiestas
Hi there. kde-workspace has been successfully split into the following repositories: powerdevil khotkeys kinfocenter kmenuedit ksysguard kwin kwrited libksysguard oxygen plasma-desktop plasma-workspace systemsettings All repositories but powerdevil are under kde/workspace, powerdevil

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Kai Uwe Broulik
> On April 1, 2014, 8:31 a.m., Kai Uwe Broulik wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 47 > > > > > > Imho it should be possible

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/ --- (Updated April 1, 2014, 12:10 p.m.) Review request for Plasma and David E

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
> On April 1, 2014, 11:16 a.m., David Edmundson wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 45 > > > > > > Given this is in a file un

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
> On April 1, 2014, 10:31 a.m., Kai Uwe Broulik wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 47 > > > > > > Imho it should be possible

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/#review54743 --- plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMa

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/#review54742 --- plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kd

Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/ --- Review request for Plasma and David Edmundson. Repository: kde-workspace