----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117041/ -----------------------------------------------------------
(Updated April 1, 2014, 8:05 p.m.) Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebastian Kügler. Changes ------- Hi Sebastian, Dominik suggested that you might give input to this review request. The code is now at a "shipitable" state. Maybe one of you core plasma guys could confirm that. There is one minor issue, though: When unchecking (and only then) the new "Restrict width on large host panel" checkbox the applet size is not updated until a resize event occurs. The other way round (checking the checkbox) it works well (applet width -- or height -- is immediately restricted). So if you see how to fix this at once that would be appreciated. If it would consume too much time to find the cause, it won't hurt to leave it like it is since in the end all applets should be ported to QML anyway. Thanks & Best regards Repository: kdeplasma-addons Description ------- Summary ------- Add two options: 1. Show confirmation before sending (to prevent accidental sending of maybe sensible data) 2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels) How does this change manifest on screen? ---------------------------------------- Settings dialog: - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png Behaviour: 1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png 2. "Appearance: Restrict width on large host panel" - turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray) - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space) Open issues ----------- - Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request? @apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin? Diffs ----- applets/pastebin/pastebinConfig.ui 540fae733c0ea738b48b3bf2b11b9f9b10bdb453 applets/pastebin/pastebin.cpp df7f534c17d5a383480f385b83948d01635641a7 applets/pastebin/pastebin.h 931057f9df4f5e875f3984df1f40869235d8297e .gitignore PRE-CREATION .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117041/diff/ Testing ------- See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical). Thanks, Gregor Mi
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
