> On April 1, 2014, 11:16 a.m., David Edmundson wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 45 > > <https://git.reviewboard.kde.org/r/117276/diff/1/?file=262163#file262163line45> > > > > Given this is in a file under "themes" we probably want to put the > > Authenticator object in the C++ and expose that to the QML then connect > > succeeded signal there. Otherwise we are trusting that the QML is doing > > the right thing. > > > > Without this one could replace a local user's lock screen theme file > > and add a backdoor.
Right, this makes a lot of sense. We have to consider what to do in Plasma Active then, which currently just shipped a theme which allows unlocking without a password. But yeah, it should be exposed through C++ which also means that we have only one object in the multi-screen setup. > On April 1, 2014, 11:16 a.m., David Edmundson wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp, > > line 78 > > <https://git.reviewboard.kde.org/r/117276/diff/1/?file=262160#file262160line78> > > > > ?? I wanted to test the info feature from KCheckpass and added a unit test for it. > On April 1, 2014, 11:16 a.m., David Edmundson wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 52 > > <https://git.reviewboard.kde.org/r/117276/diff/1/?file=262163#file262163line52> > > > > Previous behaviour (and general convention) is normally for the > > password to stay but to be selected when the password is wrong. > > > > (no idea why, everyone always ends up retyping it) well on a tty it's getting removed. I think removing the password makes a lot of sense. But I can change to make it selected, don't mind much. > On April 1, 2014, 11:16 a.m., David Edmundson wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 32 > > <https://git.reviewboard.kde.org/r/117276/diff/1/?file=262163#file262163line32> > > > > AFAIK this is now unused? no, the Authenticator is emitting the notifications, so it needs to be connected. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/#review54743 ----------------------------------------------------------- On April 1, 2014, 9:32 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117276/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 9:32 a.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: kde-workspace > > > Description > ------- > > Add password checking to screenlocker > > A new Authenticator item is introduced and exported to QML. It provides > a slot tryAuthenticate taking the password as a string. If invoked it > creates a KCheckPass object which handles the communication with the > kcheckpass binary to verify the password. If the authentication succeeded > the Authenticator emits a succeeded() signal, on failure a failed() > signal. > > The authentication process is bound to a grace timer. While this timer is > active it's not possible to authenticate again. This state is exposed > with a Q_PROPERTY and used by the UI to disable the password field and > unlock button. > > > Diffs > ----- > > plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt > PRE-CREATION > > plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp > PRE-CREATION > plasma-workspace/ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c > PRE-CREATION > plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp > 496c0128e6a240a0821848c054ed60e2c2730f04 > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml > 7aa59f81f7257db9ed8306bf732b008036c64d95 > plasma-workspace/ksmserver/config-ksmserver.h.cmake > 4b60c8c6713089db8c637827c44bb04c37a87abe > plasma-workspace/ksmserver/screenlocker/greeter/CMakeLists.txt > 53fe38b7452a179f5919e93585573038ea926d00 > plasma-workspace/ksmserver/screenlocker/greeter/authenticator.h > PRE-CREATION > plasma-workspace/ksmserver/screenlocker/greeter/authenticator.cpp > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117276/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
