----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117276/#review54743 -----------------------------------------------------------
plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt <https://git.reviewboard.kde.org/r/117276/#comment38239> That's very clever. Not really a proper review comment, I just wanted to mention it :) plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp <https://git.reviewboard.kde.org/r/117276/#comment38237> ?? plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp <https://git.reviewboard.kde.org/r/117276/#comment38241> We probably don't want this. plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <https://git.reviewboard.kde.org/r/117276/#comment38235> This isn't used plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <https://git.reviewboard.kde.org/r/117276/#comment38240> AFAIK this is now unused? plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <https://git.reviewboard.kde.org/r/117276/#comment38236> Given this is in a file under "themes" we probably want to put the Authenticator object in the C++ and expose that to the QML then connect succeeded signal there. Otherwise we are trusting that the QML is doing the right thing. Without this one could replace a local user's lock screen theme file and add a backdoor. plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <https://git.reviewboard.kde.org/r/117276/#comment38238> Previous behaviour (and general convention) is normally for the password to stay but to be selected when the password is wrong. (no idea why, everyone always ends up retyping it) - David Edmundson On April 1, 2014, 7:32 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117276/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 7:32 a.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: kde-workspace > > > Description > ------- > > Add password checking to screenlocker > > A new Authenticator item is introduced and exported to QML. It provides > a slot tryAuthenticate taking the password as a string. If invoked it > creates a KCheckPass object which handles the communication with the > kcheckpass binary to verify the password. If the authentication succeeded > the Authenticator emits a succeeded() signal, on failure a failed() > signal. > > The authentication process is bound to a grace timer. While this timer is > active it's not possible to authenticate again. This state is exposed > with a Q_PROPERTY and used by the UI to disable the password field and > unlock button. > > > Diffs > ----- > > plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt > PRE-CREATION > > plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp > PRE-CREATION > plasma-workspace/ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c > PRE-CREATION > plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp > 496c0128e6a240a0821848c054ed60e2c2730f04 > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml > 7aa59f81f7257db9ed8306bf732b008036c64d95 > plasma-workspace/ksmserver/config-ksmserver.h.cmake > 4b60c8c6713089db8c637827c44bb04c37a87abe > plasma-workspace/ksmserver/screenlocker/greeter/CMakeLists.txt > 53fe38b7452a179f5919e93585573038ea926d00 > plasma-workspace/ksmserver/screenlocker/greeter/authenticator.h > PRE-CREATION > plasma-workspace/ksmserver/screenlocker/greeter/authenticator.cpp > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117276/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
