Review Request: Checking the return value of gps_open() as condition instead of checking m_gpsdata for prevent crash when no gpsd running

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103035/ --- Review request for Plasma. Description --- Checking the return value

Re: Review Request: TaskManager: TaskAction changes from IconTasks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103004/ --- (Updated Nov. 2, 2011, 10:46 p.m.) Review request for Plasma. Changes --

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

> On Nov. 2, 2011, 9:58 p.m., Christoph Feck wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.cpp, line 37 > > > > > > Is there any specific reason why this isn't "const QVariant &icon"? All > > used

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7885 --- This review has been submitted with commit 6a500cabcedebdb8b8cd

Re: Review Request: TaskManager: Store launcher order

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/ --- (Updated Nov. 2, 2011, 10:04 p.m.) Review request for Plasma. Changes --

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7884 --- plasma/declarativeimports/qtextracomponents/qiconitem.cpp

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/ --- (Updated Nov. 2, 2011, 9:05 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7883 --- This review has been submitted with commit 67b24ecc2694e462a913

Re: Correct syntax for KRun URLs

On Wednesday 05 Heshvan 5772 20:01:54 Aaron J. Seigo wrote: > On Wednesday, November 2, 2011 19:53:46 David Baron wrote: > > KRun shoiuld be able to run an executable automatically without using the > > overloaded KRun::run. How should this be done? With arguments on the data > > string? > > can y

Re: Correct syntax for KRun URLs

On Wednesday, November 2, 2011 19:53:46 David Baron wrote: > KRun shoiuld be able to run an executable automatically without using the > overloaded KRun::run. How should this be done? With arguments on the data > string? can you give a clear example of what you are wanting to have executed? it so

Correct syntax for KRun URLs

KRun shoiuld be able to run an executable automatically without using the overloaded KRun::run. How should this be done? With arguments on the data string? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-d

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7879 --- Ship it! let's go for it ;) - Marco Martin On Nov. 1, 2011,

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > the wholesale copying of KOpenWithDialog is very unfortunate and needs to > > be avoided if at *all* possible. why is it copied instead of used directly? > > > > the really big issue is the exec()'ing of the dialog, however. > > > > it wo

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > the wholesale copying of KOpenWithDialog is very unfortunate and needs to > > be avoided if at *all* possible. why is it copied instead of used directly? > > > > the really big issue is the exec()'ing of the dialog, however. > > > > it wo

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskitem.cpp, line 362 > > > > > > in which cases would the mapping not be saved (e.g. saveMapping == > > false)? > > Craig Drummond wrote:

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > the wholesale copying of KOpenWithDialog is very unfortunate and needs to > > be avoided if at *all* possible. why is it copied instead of used directly? > > > > the really big issue is the exec()'ing of the dialog, however. > > > > it wo

Re: Review Request: TaskManager: Store launcher order

> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/strategies/desktopsortingstrategy.cpp, line 40 > > > > > > this should be a private member of the class ... as this is a > > non-exported clas

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/#review7869 --- Ship it! huzzah! first patch read to go and the others not far

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 384 > > > > > > we have a name, it should be used. it hardly matters what the eventual > > Launcher is called. shorteni

Re: KRunner Guidelines

On Tuesday, November 01, 2011 21:00:54 David Baron wrote: > On Tuesday 04 Heshvan 5772 21:48:51 Aaron J. Seigo wrote: > > On Tuesday, November 1, 2011 19:06:12 David Baron wrote: > > > Should a runner flag it hits. Right now my recoll runner should them as > > > "recoll-filename." Other runners sho

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 375 > > > > > > dialogs must not be exec()'d as they *freeze* the entire UI.. in this > > case the whole plasma-desktop

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 384 > > > > > > we have a name, it should be used. it hardly matters what the eventual > > Launcher is called. shorteni

Re: Review Request: TaskManager: Store launcher order

> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/strategies/desktopsortingstrategy.cpp, line 40 > > > > > > this should be a private member of the class ... as this is a > > non-exported clas