> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > the wholesale copying of KOpenWithDialog is very unfortunate and needs to > > be avoided if at *all* possible. why is it copied instead of used directly? > > > > the really big issue is the exec()'ing of the dialog, however. > > > > it would also be nice to be able to access individual launcher > > configuration via the individual launchers' context menu. > > > > p.s. whitespace :) > > Craig Drummond wrote: > I agree the copying is bad - but without changing kdelibs I knew of no > other way. The reason it is copied is that in KOpenWithDialog you cannot > remove the "Open with" label (or change its text), or the kurlrequester below > it. > > Aaron J. Seigo wrote: > the Open With label is settable by using the KOpenWithDialog( const > KUrl::List& urls, const QString& text, const QString& value, QWidget *parent > = 0 ); constructor, so it could be set to something sensible for this case. > as forthe KUrlRequester ... is that so bad? it allows the user to define an > arbitrary exec on disk, the ultimate "last resort". > > Craig Drummond wrote: > Just tried KOpenWithDialog, and whilst you can set the text, and hide the > checkboxes - the text entered in the url combo *must* be an application, not > a desktop file. If you select a desktop file via the file selector you get > the following error: > > "'XXX.desktop' not found, please type a valid program name." > > So, KOpenWithDialog would need updating to resolve this.
indeed; i can fix that (though not today .. already at the end of my time alotments! aaaah! why only 24 hours in a day?!) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/#review7801 ----------------------------------------------------------- On Oct. 31, 2011, 8:42 p.m., Craig Drummond wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103007/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2011, 8:42 p.m.) > > > Review request for Plasma. > > > Description > ------- > > 1. If fail to automatically find launcher, then prompt user to select from > installed applications. > 2. Add a config page, so that manualy set launchers may be adjusted. > > (Part of IconTasks' taskmanager changes) > > > Diffs > ----- > > libs/taskmanager/CMakeLists.txt 57f5f73 > libs/taskmanager/groupmanager.h acaa142 > libs/taskmanager/groupmanager.cpp 6e7ffa7 > libs/taskmanager/kapplicationselectordialog.h PRE-CREATION > libs/taskmanager/kapplicationselectordialog.cpp PRE-CREATION > libs/taskmanager/launcherconfig.h PRE-CREATION > libs/taskmanager/launcherconfig.cpp PRE-CREATION > libs/taskmanager/launcherconfig.ui PRE-CREATION > libs/taskmanager/launcherproperties.h PRE-CREATION > libs/taskmanager/launcherproperties.cpp PRE-CREATION > libs/taskmanager/launcherproperties.ui PRE-CREATION > libs/taskmanager/taskactions.cpp 0e6ba8e > libs/taskmanager/taskitem.h 5de8478 > libs/taskmanager/taskitem.cpp 0a768e5 > > Diff: http://git.reviewboard.kde.org/r/103007/diff/diff > > > Testing > ------- > > > Thanks, > > Craig Drummond > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
