> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/taskactions.cpp, line 375
> > <http://git.reviewboard.kde.org/r/103007/diff/1/?file=39955#file39955line375>
> >
> > dialogs must not be exec()'d as they *freeze* the entire UI.. in this
> > case the whole plasma-desktop shell. i must be handled asynchronously.
>
> Craig Drummond wrote:
> Good point!
This is odd. I've tried running the dialog via "show()" and connecting to the
"okClicked()" signal. However, the slot never gets called. If I change it to
"exec()" the slot does get called...
e.g. this does *not* work:
KApplicationSelectorDialog *dlg=new
KApplicationSelectorDialog(i18n("XXX"), 0L);
connect(dlg, SIGNAL(okClicked()), this, SLOT(xxx()));
dlg->show();
...but this does:
KApplicationSelectorDialog *dlg=new
KApplicationSelectorDialog(i18n("XXX"), 0L);
connect(dlg, SIGNAL(okClicked()), this, SLOT(xxx()));
dlg->exec();
(Ignore the obvious memory leak)
-----------------
However, this seems to be a general issue with plasma dialogs. e.g. if you
configure a colour for the clock dialog, plasma is frozen. Perhaps all plasma
dialogs need to be run via another process?
- Craig
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103007/#review7801
-----------------------------------------------------------
On Oct. 31, 2011, 8:42 p.m., Craig Drummond wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103007/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2011, 8:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> 1. If fail to automatically find launcher, then prompt user to select from
> installed applications.
> 2. Add a config page, so that manualy set launchers may be adjusted.
>
> (Part of IconTasks' taskmanager changes)
>
>
> Diffs
> -----
>
> libs/taskmanager/CMakeLists.txt 57f5f73
> libs/taskmanager/groupmanager.h acaa142
> libs/taskmanager/groupmanager.cpp 6e7ffa7
> libs/taskmanager/kapplicationselectordialog.h PRE-CREATION
> libs/taskmanager/kapplicationselectordialog.cpp PRE-CREATION
> libs/taskmanager/launcherconfig.h PRE-CREATION
> libs/taskmanager/launcherconfig.cpp PRE-CREATION
> libs/taskmanager/launcherconfig.ui PRE-CREATION
> libs/taskmanager/launcherproperties.h PRE-CREATION
> libs/taskmanager/launcherproperties.cpp PRE-CREATION
> libs/taskmanager/launcherproperties.ui PRE-CREATION
> libs/taskmanager/taskactions.cpp 0e6ba8e
> libs/taskmanager/taskitem.h 5de8478
> libs/taskmanager/taskitem.cpp 0a768e5
>
> Diff: http://git.reviewboard.kde.org/r/103007/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Craig Drummond
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
