----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/ -----------------------------------------------------------
(Updated Nov. 2, 2011, 9:05 p.m.) Review request for Plasma. Changes ------- 1. Don't use exec to run dialogs (except in ToggleLauncher action) 2. Replace ustom KAppltionSelectorDialog with KOpenWithDialog. KOpenWithDialog needs updating to handle .desktop files in url combo. 3. In setLauncherUrl(const KUrl&) always save mapping. In a later patch will add setLauncherUrl(LauncherItem *) where the mappnig will not be saved. 4. Run astyle to fix any whitespace issues. Description ------- 1. If fail to automatically find launcher, then prompt user to select from installed applications. 2. Add a config page, so that manualy set launchers may be adjusted. (Part of IconTasks' taskmanager changes) Diffs (updated) ----- libs/taskmanager/CMakeLists.txt 57f5f73 libs/taskmanager/groupmanager.h acaa142 libs/taskmanager/groupmanager.cpp 6e7ffa7 libs/taskmanager/launcherconfig.h PRE-CREATION libs/taskmanager/launcherconfig.cpp PRE-CREATION libs/taskmanager/launcherconfig.ui PRE-CREATION libs/taskmanager/launcherproperties.h PRE-CREATION libs/taskmanager/launcherproperties.cpp PRE-CREATION libs/taskmanager/launcherproperties.ui PRE-CREATION libs/taskmanager/taskactions.cpp 0e6ba8e libs/taskmanager/taskitem.h 5de8478 libs/taskmanager/taskitem.cpp 0a768e5 Diff: http://git.reviewboard.kde.org/r/103007/diff/diff Testing ------- Thanks, Craig Drummond
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
