Re: Review Request: Improved Button.qml in PlasmaComponents

> On Nov. 1, 2011, 9:36 p.m., Marco Martin wrote: > > Oh yeah :) Thanx! - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 -

Re: Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7850 --- This review has been submitted with commit 5729cc5ababdb4d7a54b

Re: Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7844 --- Ship it! - Marco Martin On Nov. 1, 2011, 9:20 p.m., Mark Gais

Re: Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- (Updated Nov. 1, 2011, 9:20 p.m.) Review request for KDE Runtime, Plasma a

Re: Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7842 --- well done, getting near :) only last thing: could you make it us

Re: Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- (Updated Nov. 1, 2011, 8:52 p.m.) Review request for KDE Runtime, Plasma a

Re: QML device notifier

Hi all, it is merge now. the device notifier is now 100% qml. the feature set and the look should be a nearly exact replica... please test ;) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listin

Re: Review Request: Improved Button.qml in PlasmaComponents

> On Nov. 1, 2011, 7:20 p.m., Marco Martin wrote: > > plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 60 > > > > > > width of the buttons should always be the same unless explicitly > > resized by th

Re: KRunner Guidelines

On Tuesday 04 Heshvan 5772 21:48:51 Aaron J. Seigo wrote: > On Tuesday, November 1, 2011 19:06:12 David Baron wrote: > > Should a runner flag it hits. Right now my recoll runner should them as > > "recoll-filename." Other runners show "Mail to soandso" or "Run > > this-app." However, many others ju

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, converting to > > the local timezone there ( KSystem

Re: KRunner Guidelines

On Tuesday, November 1, 2011 19:06:12 David Baron wrote: > Should a runner flag it hits. Right now my recoll runner should them as > "recoll-filename." Other runners show "Mail to soandso" or "Run this-app." > However, many others just yield the file name with no hint of why the user > is seeing th

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 600 > > > > > > this is a misuse of QAction. you can add QActions to a QAction and that > > parent QAction becomes the

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review7834 --- A Calendar object is supposed to mirror what's in akonadi, so we

Re: Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/#review7830 --- i like the effect of having an animated press effect. this comes

Review Request: Improved Button.qml in PlasmaComponents

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/ --- Review request for KDE Runtime, Plasma and Marco Martin. Description -

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7826 --- to me it would be fine (even tough there are starting to be quit

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/ --- (Updated Nov. 1, 2011, 6:43 p.m.) Review request for KDE Runtime and Plasm

Re: PlasmaComponents.Button missing feature: use system icons!

On Tuesday 01 November 2011, Mark wrote: > > as i already repeated, i have to move the image provider. > > QIcon::fromTheme, exactly as kiconloader are c++ functions, so no way to > > access those from qml if a proper binding is not written :p > > > > Cheers, > > Marco Martin > > > > I'm guessing

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

> On Nov. 1, 2011, 5:08 p.m., Aaron J. Seigo wrote: > > looking good :) all that's left is the coding style compliance (whitespace > > and formatting issues) and resetting d->launcherUrl appropriately in > > setTaskPointer and then this can go in! woo! > > Aaron J. Seigo wrote: > btw... an

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/ --- (Updated Nov. 1, 2011, 5:27 p.m.) Review request for Plasma. Changes ---

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

> On Nov. 1, 2011, 5:08 p.m., Aaron J. Seigo wrote: > > looking good :) all that's left is the coding style compliance (whitespace > > and formatting issues) and resetting d->launcherUrl appropriately in > > setTaskPointer and then this can go in! woo! btw... an astyle command that will catch

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/#review7820 --- looking good :) all that's left is the coding style compliance (

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > the wholesale copying of KOpenWithDialog is very unfortunate and needs to > > be avoided if at *all* possible. why is it copied instead of used directly? > > > > the really big issue is the exec()'ing of the dialog, however. > > > > it wo

KRunner Guidelines

Should a runner flag it hits. Right now my recoll runner should them as "recoll-filename." Other runners show "Mail to soandso" or "Run this-app." However, many others just yield the file name with no hint of why the user is seeing this one. Icons suggest the file's type or mime-type rather than

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > a few issues with this patch, which can be divided into three types: > > > > * over simplification of the menu; i am all for reducing the items in this > > menu, including moving more to the "Advanced" submenu (which should > > probably b

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 384 > > > > > > we have a name, it should be used. it hardly matters what the eventual > > Launcher is called. shorteni

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/ --- (Updated Nov. 1, 2011, 5 p.m.) Review request for Plasma. Changes --

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > a few issues with this patch, which can be divided into three types: > > > > * over simplification of the menu; i am all for reducing the items in this > > menu, including moving more to the "Advanced" submenu (which should > > probably b

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskmanagerrulesrc, line 13 > > > > > > perhaps an entry for kcmshell4 as well? > > Craig Drummond wrote: > Currently kcmshell4 *cannot* b

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

> On Nov. 1, 2011, 3:34 p.m., Marco Martin wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > since here only write makes sense, you need a method I'm not getting you. What do yo

Re: Review Request: TaskManager: TaskAction changes from IconTasks

> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 135 > > > > > > why a property for this? why not simply: > > > > if (!act->toolTip().isEmpty()) { Using "if (!

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

> On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > could these be automatically detected? e.g. if it can't be resolved > > into a pat

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

> On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > could these be automatically detected? e.g. if it can't be resolved > > into a pat

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskitem.cpp, line 416 > > > > > > if isStartupItem, d->task should be null as well ... > > Craig Drummond wrote: > Sorry, not sure what

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7806 --- plasma/declarativeimports/qtextracomponents/qiconitem.h

Re: Review Request: TaskManager: Store launcher order

> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskitem.cpp, lines 171-189 > > > > > > have you done any time measurements on how long this method takes? it > > will be called potentially

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskmanagerrulesrc, line 13 > > > > > > perhaps an entry for kcmshell4 as well? > > Craig Drummond wrote: > Currently kcmshell4 *cannot* b

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

> On Nov. 1, 2011, 3:09 p.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.h, line 31 > > > > > > could these be automatically detected? e.g. if it can't be resolved > > into a pat

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7802 --- plasma/declarativeimports/qtextracomponents/qiconitem.h

Re: Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/#review7801 --- the wholesale copying of KOpenWithDialog is very unfortunate and

Re: PlasmaComponents.Button missing feature: use system icons!

On Tue, Nov 1, 2011 at 3:45 PM, Marco Martin wrote: > On Monday 31 October 2011, Mark wrote: > > > > > If not, then what does it do? > > > > > > the icon caching is per-application. it isn't a global, to-disk cache > > > rendered > > > icons. > > > > This really sucks! Why is QIcon only working i

Re: Review Request: TaskManager: Store launcher order

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/#review7798 --- usual comment about whitespace correctness; otherwise a few comm

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

> On Nov. 1, 2011, 2:31 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskitem.cpp, lines 378-385 > > > > > > create KSysGuard::Processes on the stack to prevent the need to delete > > it later? these kinds of l

Re: PlasmaComponents.Button missing feature: use system icons!

On Monday 31 October 2011, Mark wrote: > > > If not, then what does it do? > > > > the icon caching is per-application. it isn't a global, to-disk cache > > rendered > > icons. > > This really sucks! Why is QIcon only working inside plasma!? It makes no > sense at all since QIcon::fromTheme just

Re: Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/#review7797 --- looks pretty good; whitespace needs cleaning up throughougt the

Re: QML Performance Tips

On Tuesday, November 01, 2011 11:15:15 Aaron J. Seigo wrote: > On Tuesday, November 1, 2011 10:45:27 Sebastian Kügler wrote: > > http://harmattan- > > dev.nokia.com/docs/library/html/guide/html/Developer_Library_Best_practic > > es_ for_application_development_QML_performance_tips_and_tricks.html >

Re: Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

On Tuesday, November 1, 2011 11:34:02 Sebastian Kügler wrote: > On Tuesday, November 01, 2011 11:17:20 Aaron J. Seigo wrote: > > > On Oct. 30, 2011, 8:03 a.m., Aaron J. Seigo wrote: > > > > why is a CMakeLists.txt needed? plasmapkg is enough, no? > > > > > > Sebastian Kügler wrote: > > > CMakeL

Re: Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

On Tuesday, November 01, 2011 11:17:20 Aaron J. Seigo wrote: > > On Oct. 30, 2011, 8:03 a.m., Aaron J. Seigo wrote: > > > why is a CMakeLists.txt needed? plasmapkg is enough, no? > > > > Sebastian Kügler wrote: > > CMakeLists.txt is needed if you want to package the package (for OBS, > > f

Re: Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

> On Oct. 30, 2011, 8:03 a.m., Aaron J. Seigo wrote: > > why is a CMakeLists.txt needed? plasmapkg is enough, no? > > Sebastian Kügler wrote: > CMakeLists.txt is needed if you want to package the package (for OBS, for > example). shouldn't that be part of the publishing step then? - Aaro

Re: QML Performance Tips

On Tuesday, November 1, 2011 10:45:27 Sebastian Kügler wrote: > http://harmattan- > dev.nokia.com/docs/library/html/guide/html/Developer_Library_Best_practices_ > for_application_development_QML_performance_tips_and_tricks.html some nice points in there indeed .. i did spot a common programming e

Re: Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

> On Oct. 30, 2011, 8:03 a.m., Aaron J. Seigo wrote: > > why is a CMakeLists.txt needed? plasmapkg is enough, no? CMakeLists.txt is needed if you want to package the package (for OBS, for example). - Sebastian --- This is an automatica

Re: IconTasks taskmanager changes

On Monday, October 31, 2011 20:49:13 Craig Drummond wrote: > On 27/10/11 15:29, Aaron J. Seigo wrote: > > On Thursday, October 27, 2011 14:24:26 Craig Drummond wrote: > >> 1. TaskAction changes - these are self contained anyway. > >> 2. Launcher matching - mainly TaskItem::launcherUrl() changes. >

QML Performance Tips

Hi, For everybody working with QML, the following pages are worth a read: http://harmattan- dev.nokia.com/docs/library/html/guide/html/Developer_Library_Best_practices_for_application_development_QML_performance_tips_and_tricks.html Cheers, -- sebas http://www.kde.org | http://vizZzion.org | G

Review Request: TaskManager: Prompt user when automatic task to launcher mathing fails.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/ --- Review request for Plasma. Description --- 1. If fail to automaticall

Review Request: TaskManager: Store launcher order

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/ --- Review request for Plasma. Description --- 1. Store the order in whic

Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/ --- Review request for Plasma. Description --- Add more KTrader queries w

Review Request: TaskManager: TaskAction changes from IconTasks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103004/ --- Review request for Plasma. Description --- 1. Add NewInstance action