> On Nov. 1, 2011, 2:05 p.m., Aaron J. Seigo wrote: > > a few issues with this patch, which can be divided into three types: > > > > * over simplification of the menu; i am all for reducing the items in this > > menu, including moving more to the "Advanced" submenu (which should > > probably be renamed to "More Actions"), but this patch goes too far and > > renders the BasicMenu far, far les useful than it ought to be > > * custom properties in the QActions are unneeded (see inline comments for > > how these can be handled without custom properties) > > * whitespace correctness (the most trivial and least important of the > > issues)
Didn’t think the 'basic' option would go down to well :-) Shall I just remove it from this patch? I still think they could be with simplifying... - Craig ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103004/#review7794 ----------------------------------------------------------- On Oct. 31, 2011, 8:40 p.m., Craig Drummond wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103004/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2011, 8:40 p.m.) > > > Review request for Plasma. > > > Description > ------- > > 1. Add NewInstance action to launch a new instance of an application. > 2. Move toggle launcher action out of advanced menu. > 3. Don't show application name in 'Show A Launcher' action, as might not know > the real name at this time (e.g. no desktop file read). > 4. Add application actions, to be shown at the top of the right-click menu. > IconTasks uses this to show recent docuents, dock manager menu items, and > unity items. > 5. A ToolTipMenu class is created, so that tooltips may be give for menu > items. This is so that IconTasks can display the full path of a documents in > the recent documents menu. > 6. Add option to have only basic window controls in menu. > > > Diffs > ----- > > libs/taskmanager/taskactions.h 2b5a641 > libs/taskmanager/taskactions.cpp 0e6ba8e > libs/taskmanager/taskactions_p.h 913966c > > Diff: http://git.reviewboard.kde.org/r/103004/diff/diff > > > Testing > ------- > > > Thanks, > > Craig Drummond > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
