> On Nov. 1, 2011, 5:08 p.m., Aaron J. Seigo wrote: > > looking good :) all that's left is the coding style compliance (whitespace > > and formatting issues) and resetting d->launcherUrl appropriately in > > setTaskPointer and then this can go in! woo!
btw... an astyle command that will catch most if not all formatting issues in the file can be found here: http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103005/#review7820 ----------------------------------------------------------- On Nov. 1, 2011, 5 p.m., Craig Drummond wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103005/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2011, 5 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Add more KTrader queries when attempting to match a task to a launcher. > > (Part of IconTasks' taskmanager changes) > > > Diffs > ----- > > libs/taskmanager/CMakeLists.txt 57f5f73 > libs/taskmanager/startup.h 997eb7e > libs/taskmanager/startup.cpp e4df7c7 > libs/taskmanager/task.h 45acd5a > libs/taskmanager/task_win.cpp ea03004 > libs/taskmanager/task_x11.cpp 04af0c7 > libs/taskmanager/taskitem.h 5de8478 > libs/taskmanager/taskitem.cpp 0a768e5 > libs/taskmanager/taskmanagerrulesrc PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103005/diff/diff > > > Testing > ------- > > > Thanks, > > Craig Drummond > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
