> On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > the wholesale copying of KOpenWithDialog is very unfortunate and needs to > > be avoided if at *all* possible. why is it copied instead of used directly? > > > > the really big issue is the exec()'ing of the dialog, however. > > > > it would also be nice to be able to access individual launcher > > configuration via the individual launchers' context menu. > > > > p.s. whitespace :)
I agree the copying is bad - but without changing kdelibs I knew of no other way. The reason it is copied is that in KOpenWithDialog you cannot remove the "Open with" label (or change its text), or the kurlrequester below it. > On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/kapplicationselectordialog.cpp, line 484 > > <http://git.reviewboard.kde.org/r/103007/diff/1/?file=39948#file39948line484> > > > > should be removed. Oops :-( > On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskactions.cpp, line 375 > > <http://git.reviewboard.kde.org/r/103007/diff/1/?file=39955#file39955line375> > > > > dialogs must not be exec()'d as they *freeze* the entire UI.. in this > > case the whole plasma-desktop shell. i must be handled asynchronously. Good point! > On Nov. 1, 2011, 3:07 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskitem.cpp, line 362 > > <http://git.reviewboard.kde.org/r/103007/diff/1/?file=39957#file39957line362> > > > > in which cases would the mapping not be saved (e.g. saveMapping == > > false)? In another patch (not done yet), LauncherItem::associateItemIfMatches() calls setLauncherUrl on the task. But as this was not done by the user, I didnt want to save the mapping. - Craig ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103007/#review7801 ----------------------------------------------------------- On Oct. 31, 2011, 8:42 p.m., Craig Drummond wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103007/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2011, 8:42 p.m.) > > > Review request for Plasma. > > > Description > ------- > > 1. If fail to automatically find launcher, then prompt user to select from > installed applications. > 2. Add a config page, so that manualy set launchers may be adjusted. > > (Part of IconTasks' taskmanager changes) > > > Diffs > ----- > > libs/taskmanager/CMakeLists.txt 57f5f73 > libs/taskmanager/groupmanager.h acaa142 > libs/taskmanager/groupmanager.cpp 6e7ffa7 > libs/taskmanager/kapplicationselectordialog.h PRE-CREATION > libs/taskmanager/kapplicationselectordialog.cpp PRE-CREATION > libs/taskmanager/launcherconfig.h PRE-CREATION > libs/taskmanager/launcherconfig.cpp PRE-CREATION > libs/taskmanager/launcherconfig.ui PRE-CREATION > libs/taskmanager/launcherproperties.h PRE-CREATION > libs/taskmanager/launcherproperties.cpp PRE-CREATION > libs/taskmanager/launcherproperties.ui PRE-CREATION > libs/taskmanager/taskactions.cpp 0e6ba8e > libs/taskmanager/taskitem.h 5de8478 > libs/taskmanager/taskitem.cpp 0a768e5 > > Diff: http://git.reviewboard.kde.org/r/103007/diff/diff > > > Testing > ------- > > > Thanks, > > Craig Drummond > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
