On Monday, October 31, 2011 20:49:13 Craig Drummond wrote: > On 27/10/11 15:29, Aaron J. Seigo wrote: > > On Thursday, October 27, 2011 14:24:26 Craig Drummond wrote: > >> 1. TaskAction changes - these are self contained anyway. > >> 2. Launcher matching - mainly TaskItem::launcherUrl() changes. > >> 3. Launcher ordering - basically everything else. > >> > >> Would that be enough? > > I've now created 4 review requests for my task manager changes. these are: > > 1. TaskAction changes > 2. Launcher/task matching > 3. Saving of launcher order > 4. Prompting of user when automatic launcher/task matching fails.
i'll go through these shortly.. thanks... > p.s. My reviewboard account is my @kde.org address, but plasma-devel is > my @gmx.net address (which @kde forwards to). So my reviews are awaiting > approval. Is there anyway I can get round this? So plasma-devel knows > that emails from my @kde.org do not need approval? i've already made the adjustments in the mailing list config :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
