Re: Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

If we have every file-type selected on default for "Show files matching", that will be fine, but I'm not sure if deselecting all file types for "Hide files matching" would work, because if the user enters some filter, say "foo*" even then foo will be displayed, because its not selected in the MIME

Re: Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

I tried to add check boxes to enable or disable one or both of the Filter and MIME types, but this might unnecessarily complicate the code. Just informing the user should be enough. On Mon, Mar 9, 2009 at 12:59 AM, Chani wrote: > > --- > Th

Review of KDE 4.2

Hi panel/plasma team, Some of our users have done some reviews about kde 4 and i think this can be usefull to share it with you. I won't spend time on all the good points but i would like to speak about some blocker issues ( i will do bugreports later but i prefer to do this mail first) -1- If

Re: Review Request: a thinghiesimilar to the toolbox on zoomed out view

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/265/#review421 --- ahahaha. we need to talk more. :) I started work on this today, but from

Re: Review Request: Tasks applet: group popup with real task items

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/ --- (Updated 2009-03-08 15:22:38.552515) Review request for Plasma, Aaron Seigo and M

Re: Review Request: Tasks applet: group popup with real task items

> On 2009-03-08 09:19:15, Marco Martin wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp, line > > 565 > > > > > > using an event filter just to hide the window on lost focus seems a bit > > ov

Re: Review Request: Adds support for tabs to the comic applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/251/ --- (Updated 2009-03-08 14:47:11.968191) Review request for Plasma. Changes ---

Review Request: a thinghiesimilar to the toolbox on zoomed out view

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/265/ --- Review request for Plasma. Summary --- A problem of the zoomed out view is t

Re: Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

> On 2009-03-08 12:29:21, Chani wrote: > > the patch itself looks fine, but... isn't there a way we can make the UI > > better so that there's no need for a tooltip at all? One way to avoid unwanted behavior without changing the ui would be to have every file-type selected on default for "Show

Re: Review Request: Adds support for tabs to the comic applet

> On 2009-03-08 13:11:10, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp, line 471 > > > > > > why do you need this check? are there other parts of the code messing > > with your tab lists? true, that

Re: Review Request: Adds support for tabs to the comic applet

> On 2009-03-08 13:11:10, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp, line 446 > > > > > > so... your config dialog only allows you to configure the comic for the > > current tab? awww. > > wel

Re: Review Request: Create and destroy panels as their screens come and go

On March 8, 2009 13:47:57 Aike J Sommer wrote: > > there's a bug or two on bko that this fixes iirc, close them when you > > commit :) > > Tried that, but bugzilla tells me i have no permissions to do so... > Anything i can do about that?? get on irc and bug someone to give you permissions :) --

Re: Review Request: Create and destroy panels as their screens come and go

> there's a bug or two on bko that this fixes iirc, close them when you > commit :) Tried that, but bugzilla tells me i have no permissions to do so... Anything i can do about that?? The commits are: 937003, 937005 :-) -- Aike J Sommer http://aikesommer.name/ _

Re: Review Request: Adds support for tabs to the comic applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/251/#review414 --- I haven't tried this patch.. just a quick review before I go do other st

Re: Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/262/#review413 --- the patch itself looks fine, but... isn't there a way we can make the UI

Re: Review Request: Make taskmanager use kephal instead of QDW

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/258/#review412 --- Ship it! sounds good to me. - Chani On 2009-03-08 07:27:56, Aike J S

Re: Review Request: Update struts on screen-added/-removed

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/257/#review411 --- Ship it! such a minimal patch that you probably could have skipped the

Re: Review Request: Create and destroy panels as their screens come and go

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/264/#review410 --- Ship it! +1 there's a bug or two on bko that this fixes iirc, close the

Review Request: Create and destroy panels as their screens come and go

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/264/ --- Review request for Plasma. Summary --- This delays creation of PanelView's u

Review Request: Addition to UI for Config page "Filter" in FolderView applet to make behavior clear.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/262/ --- Review request for Plasma. Summary --- This changes the UI for the configura

Review Request: Move dragEnter and dragMove events showing of drop zone from panelview to containment.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/261/ --- Review request for Plasma. Summary --- Currently, the drop zone that's shown

Re: Review Request: Tasks applet: group popup with real task items

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/#review406 --- Ship it! other a single issue it looks good (and an improvement for sur

Ideas on improving the manual grouping and sorting in the tasks applet

Hi, i thought about improving the grouping and sorting and was wondering if this sound like a good idea =) In order to remove the current grouping key (alt) i thought it would be nice if there was some visual feedback when dragging tasks around in the taskbar. For grouping one would have to d

Review Request: Make taskmanager use kephal instead of QDW

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/258/ --- Review request for Plasma. Summary --- This little patch makes the taskmanag

Review Request: Update struts on screen-added/-removed

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/257/ --- Review request for Plasma. Summary --- This is just a minimal patch that upd

How to check if window really was closed?

Hi, i noticed that windows which are blocked by a modal dialog cannot be closed. While this is fine i think the window should be activated instead so the user can give the required input. This annoyed me only when closing a window with the taskbar since only there i don't see the window which i

Review Request: Tasks applet: group popup with real task items

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- This pa