----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/264/ -----------------------------------------------------------
Review request for Plasma. Summary ------- This delays creation of PanelView's until there is an actual screen for them. It also removes the views when the screen is removed. That solves a few problems with panels that have all empty sizes and are thus not visible even though they are positioned correctly when a screen is plugged in. This patch also removes a duplicate sanity-check and sets the size for panels to 100% if it is empty, so that panels which are saved in the appletsrc with a 0 size are visible again. Diffs ----- /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopcorona.cpp 936453 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 936453 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 936453 Diff: http://reviewboard.kde.org/r/264/diff Testing ------- Did a couple of iterations with starting and stopping plasma, as well as adding and removing my second screen. In between i changed the size of the panel and added/removed applets. All changes were correctly saved and restored and it did not crash on me!! :-) Thanks, Aike J _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel