----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/#review406 -----------------------------------------------------------
Ship it! other a single issue it looks good (and an improvement for sure) /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp <http://reviewboard.kde.org/r/256/#comment239> using an event filter just to hide the window on lost focus seems a bit overkill, try to just set the dialog window flag (look ad QWidget::setWindowFlags()) even instead of KWidowSystem::setState. popupapplet doesn't use it because of problems with drag and drop and extender items, but here we don't have such problems - Marco On 2009-03-08 03:24:54, Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/256/ > ----------------------------------------------------------- > > (Updated 2009-03-08 03:24:54) > > > Review request for Plasma, Aaron Seigo and Marco Martin. > > > Summary > ------- > > This patch replaces the currently used TasksMenu with a Plasma::Dialog which > shows the same LayoutWidget which is also used in the expanded group. > This makes it possible to use the right click menu on items in the popup. > I couldn't find any drawbacks compared to the previous TasksMenu. > Drag&Drop support for sorting and grouping is not implemented though also not > really neccessary (but i think it would be possible). > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 936639 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 936639 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 936639 > > Diff: http://reviewboard.kde.org/r/256/diff > > > Testing > ------- > > Tested locally. > unfortunately i don't get theming with my svn installation so i couldn't test > if it looks nice. > > > Thanks, > > Christian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
