> On 2009-03-08 09:19:15, Marco Martin wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp, line > > 565 > > <http://reviewboard.kde.org/r/256/diff/1/?file=2076#file2076line565> > > > > using an event filter just to hide the window on lost focus seems a bit > > overkill, try to just set the dialog window flag (look ad > > QWidget::setWindowFlags()) even instead of KWidowSystem::setState. > > popupapplet doesn't use it because of problems with drag and drop and > > extender items, but here we don't have such problems
the Qt::Popup flag doesn't work for me as a replacement of the eventFilter. If i use the Qt::Popup flag i always need an additional click on the taskbar to make the popup disappear. Even if i activate an entry from the popup the popup wont dissappear. With the eventFilter the popup is totally non invasive and behaves like it should. i couldn't figure out how to set NET::skipTaskbar | NET::skipPager with the setWindowFlags() function. the resizing issue we discussed on irc can be worked around (or fixed?) by resizing m_offscreenWidget instead of the popupDialog - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/256/#review406 ----------------------------------------------------------- On 2009-03-08 03:24:54, Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/256/ > ----------------------------------------------------------- > > (Updated 2009-03-08 03:24:54) > > > Review request for Plasma, Aaron Seigo and Marco Martin. > > > Summary > ------- > > This patch replaces the currently used TasksMenu with a Plasma::Dialog which > shows the same LayoutWidget which is also used in the expanded group. > This makes it possible to use the right click menu on items in the popup. > I couldn't find any drawbacks compared to the previous TasksMenu. > Drag&Drop support for sorting and grouping is not implemented though also not > really neccessary (but i think it would be possible). > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 936639 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 936639 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 936639 > > Diff: http://reviewboard.kde.org/r/256/diff > > > Testing > ------- > > Tested locally. > unfortunately i don't get theming with my svn installation so i couldn't test > if it looks nice. > > > Thanks, > > Christian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
