----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/261/ -----------------------------------------------------------
Review request for Plasma. Summary ------- Currently, the drop zone that's shown when hovering stuff over the panel, is being shown through a call to showDropZone from panelview. In those drag events, there is a check if what is hovering the panel, can actually be dropped there. Now that extenderitems also use QDrag, this if statement has already grown to 4 lines. I think it makes more sense to move this to containment, where that check is already being done, and avoid the duplication. This also avoids the need to use the "plasma/extenderitem" string in the mimetype check there, since in libplasma, we can use ExtenderItemMimeDate::mimeType() to obtain this string, and I would like to keep that class private. Diffs ----- /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h 936720 /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 936720 /trunk/KDE/kdelibs/plasma/containment.cpp 936720 /trunk/KDE/kdelibs/plasma/extenderitem.cpp 936720 Diff: http://reviewboard.kde.org/r/261/diff Testing ------- I've tested hovering different things over the panel, and the drop zone is shown as expected. Thanks, Rob _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
