Re: [PR] Finalize `log4j-transform-maven-shade-plugin-extensions` transfer [logging-log4j-transform]

2024-03-27 Thread via GitHub
ppkarwasz commented on PR #42: URL: https://github.com/apache/logging-log4j-transform/pull/42#issuecomment-2022150075 Sorry, I didn't notice the bug fix. Closes #87. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1540190416 ## src/log4net.Tests/Util/SystemInfoTest.cs: ## @@ -55,9 +55,9 @@ public void TestAssemblyLocationInfoDoesNotThrowNotSupportedExceptionForDynamicA priv

Re: [I] `Log4j2PluginsCacheFileTransformer` deletes cache if only one is available [logging-log4j-transform]

2024-03-27 Thread via GitHub
ppkarwasz closed issue #87: `Log4j2PluginsCacheFileTransformer` deletes cache if only one is available URL: https://github.com/apache/logging-log4j-transform/issues/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540640622 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/Tags.java: ## @@ -14,25 +14,20 @@ * See the License for the specific language governing p

[I] Run environment-independent tests in full parallel mode (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz opened a new issue, #2417: URL: https://github.com/apache/logging-log4j2/issues/2417 An increasing amount of tests, especially in Log4j Core 3.x does not depend on the environment with two exceptions: - they might read values from `PropertiesUtil`, - they might write logs

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540657373 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/Tags.java: ## @@ -14,25 +14,20 @@ * See the License for the specific language governing p

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540662283 ## log4j-jctools/src/main/java/org/apache/logging/log4j/jctools/JCToolsRecyclerFactoryProvider.java: ## @@ -52,7 +51,7 @@ public String getName() { @Overr

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400#discussion_r1540850963 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/MessageFactory2Adapter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.18 to 7.17.19 (logging-log4j2)

2024-03-27 Thread via GitHub
github-actions[bot] merged PR #2418: URL: https://github.com/apache/logging-log4j2/pull/2418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1541312483 ## log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java: ## @@ -201,11 +204,14 @@ public static void checkMessageFactory(final ExtendedLo

Re: [PR] Remove `log4j-kubernetes` in version 2.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz merged PR #2412: URL: https://github.com/apache/logging-log4j2/pull/2412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Remove `log4j-kubernetes` in version 3.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz merged PR #2408: URL: https://github.com/apache/logging-log4j2/pull/2408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Remove `log4j-kubernetes` in version 2.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on PR #2412: URL: https://github.com/apache/logging-log4j2/pull/2412#issuecomment-2023126966 Closes #2218. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] Remove `log4j-kubernetes` module (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz closed issue #2218: Remove `log4j-kubernetes` module URL: https://github.com/apache/logging-log4j2/issues/2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Remove `log4j-kubernetes` in version 3.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on PR #2408: URL: https://github.com/apache/logging-log4j2/pull/2408#issuecomment-2023127985 Closes #2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz closed issue #2151: Log4j incompatible with recent kubernetes-client URL: https://github.com/apache/logging-log4j2/issues/2151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-2023138028 I am closing this, since a new `kubernetes-log4j` lookup is available since version 6.11.0 of Kubernetes Client (cf. [announcement](https://github.com/fabric8io/kubernetes-

Re: [I] Remove `log4j-kubernetes` module (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on issue #2218: URL: https://github.com/apache/logging-log4j2/issues/2218#issuecomment-2023146978 An improved `kubernetes-log4j` module is available since Kubernetes Client version 6.11.0 (cf. [announcement](https://github.com/fabric8io/kubernetes-client/releases/tag/v6

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541420446 ## src/log4net/Appender/BufferingAppenderSkeleton.cs: ## @@ -437,7 +437,7 @@ protected override void Append(LoggingEvent loggingEvent) loggingEvent.Fix =

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541475884 ## src/log4net/ILog.cs: ## @@ -216,7 +216,7 @@ public interface ILog : ILoggerWrapper /// /// /// -void DebugFormat(IFormatProvider provider

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541533057 ## src/log4net/Appender/BufferingAppenderSkeleton.cs: ## @@ -437,7 +437,7 @@ protected override void Append(LoggingEvent loggingEvent) loggingEvent.Fi

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541538986 ## src/log4net/ILog.cs: ## @@ -216,7 +216,7 @@ public interface ILog : ILoggerWrapper /// /// /// -void DebugFormat(IFormatProvider provi

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541720526 ## src/log4net/Core/LogImpl.cs: ## @@ -326,7 +329,7 @@ public virtual void DebugFormat(string format, object arg0, object arg1, object /// methods instead.

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil merged PR #131: URL: https://github.com/apache/logging-log4net/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-27 Thread via GitHub
rgoers closed pull request #2385: 2214 - Add support for ScopedContext URL: https://github.com/apache/logging-log4j2/pull/2385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Scoped context (logging-log4j2)

2024-03-27 Thread via GitHub
rgoers opened a new pull request, #2419: URL: https://github.com/apache/logging-log4j2/pull/2419 This adds support for a ScopedContext and a ResourceLogger as requested in https://github.com/apache/logging-log4j-kotlin/issues/71 and similar to https://github.com/apache/logging-log4j2/discus

[PR] Nullable and modernization part 6 (logging-log4net)

2024-03-27 Thread via GitHub
erikmav opened a new pull request, #132: URL: https://github.com/apache/logging-log4net/pull/132 Adjusted nullability on some classes after applying the 3.0 binary to two existing projects that have nullable enabled. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2024058588 For #124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.1 [logging-log4j-samples]

2024-03-27 Thread via GitHub
dependabot[bot] closed pull request #118: Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.1 URL: https://github.com/apache/logging-log4j-samples/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.1 [logging-log4j-samples]

2024-03-27 Thread via GitHub
dependabot[bot] commented on PR #118: URL: https://github.com/apache/logging-log4j-samples/pull/118#issuecomment-2024192976 Superseded by #121. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.2 [logging-log4j-samples]

2024-03-27 Thread via GitHub
dependabot[bot] opened a new pull request, #121: URL: https://github.com/apache/logging-log4j-samples/pull/121 Bumps [com.fasterxml.woodstox:woodstox-core](https://github.com/FasterXML/woodstox) from 6.5.1 to 6.6.2. Commits https://github.com/FasterXML/woodstox/commit/3bed2621

[PR] Bump org.scala-lang:scala3-library_3 from 3.4.0 to 3.4.1 [logging-log4j-scala]

2024-03-27 Thread via GitHub
dependabot[bot] opened a new pull request, #50: URL: https://github.com/apache/logging-log4j-scala/pull/50 Bumps [org.scala-lang:scala3-library_3](https://github.com/scala/scala3) from 3.4.0 to 3.4.1. Release notes Sourced from https://github.com/scala/scala3/releases";>org.scala-l

Re: [PR] Bump org.scala-lang:scala3-library_3 from 3.4.0 to 3.4.1 [logging-log4j-scala]

2024-03-27 Thread via GitHub
github-actions[bot] merged PR #50: URL: https://github.com/apache/logging-log4j-scala/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

Re: [PR] Scoped context (logging-log4j2)

2024-03-27 Thread via GitHub
rocketraman commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2024335371 > All events in a ResourceLogger use ParameterizedMapMessage. When logging it behaves like a ParameterizedMessage in that formatMessage only returns the message directly being

Re: [PR] Scoped context (logging-log4j2)

2024-03-27 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2024398297 @rocketraman I did look into that and what you are asking for just can't be implemented in a reasonable way without significant mods to the API and will likely impact performance. T

Re: [PR] Scoped context (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2024651863 @rgoers, > @rocketraman I did look into that and what you are asking for just can't be implemented in a reasonable way without significant mods to the API and will likely

Re: [I] Issue with Duration Parsing (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on issue #1963: URL: https://github.com/apache/logging-log4j2/issues/1963#issuecomment-2024670784 @ppkarwasz, if there are no other system properties that need a `TypeConverter`, but the Kubernetes module, which is planned to be removed, remove this `TypeConverter` along with

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1542564612 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to t

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1542572496 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licens

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1542583829 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to t

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
DanAtkinson opened a new pull request, #133: URL: https://github.com/apache/logging-log4net/pull/133 Hello I noticed an issue on the Release Notes page which had the wrong version. I have corrected this. Apologies if it's in the wrong place - I could find no other reference to

[I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
NicoCV opened a new issue, #134: URL: https://github.com/apache/logging-log4net/issues/134 We're using Log4Net (2.0.15.0-.NET 4.5) in WCF services hosted in IIS. On our production environments from time to times we're experiencing crash of the application pool with following error:

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #132: URL: https://github.com/apache/logging-log4net/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #133: URL: https://github.com/apache/logging-log4net/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-11 to 1.5.6-1 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2422: URL: https://github.com/apache/logging-log4j2/pull/2422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.springframework.cloud:spring-cloud-context from 4.1.1 to 4.1.2 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2421: URL: https://github.com/apache/logging-log4j2/pull/2421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil commented on PR #133: URL: https://github.com/apache/logging-log4net/pull/133#issuecomment-2025006634 @DanAtkinson the new version is live: https://logging.apache.org/log4net/release/release-notes.html -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-11 to 1.5.6-1 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2423: URL: https://github.com/apache/logging-log4j2/pull/2423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
DanAtkinson commented on PR #133: URL: https://github.com/apache/logging-log4net/pull/133#issuecomment-2025031228 Thanks for the quick turnaround! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump spring-boot.version from 3.2.3 to 3.2.4 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2398: URL: https://github.com/apache/logging-log4j2/pull/2398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Scoped context (logging-log4j2)

2024-03-28 Thread via GitHub
rocketraman commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2025107929 @rgoers > If you have other requirements for how the data should be formatted I am sure JsonTemplateLayout could be enhanced to support it, if it can't do it already.

[I] `log4j-docgen` cannot convert method references with multiple arguments in Javadoc to AsciiDoc [logging-log4j-tools]

2024-03-28 Thread via GitHub
vy opened a new issue, #110: URL: https://github.com/apache/logging-log4j-tools/issues/110 The following Javadoc (copied from `org.apache.logging.log4j.core.filter.AbstractFilter`) gets converted to an invalid AsciiDoc due to whitespace in between method arguments: ``` Garbage-free no

[PR] Fix IndexOutOfRangeException in LogLog.LogReceived (#134) (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil opened a new pull request, #135: URL: https://github.com/apache/logging-log4net/pull/135 fixes #134 IndexOutOfRangeException in LogLog.LogReceived -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Deprecate `o.a.l.l.c.a.r.a.Duration` class for removal (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz opened a new pull request, #2425: URL: https://github.com/apache/logging-log4j2/pull/2425 We deprecate the [`o.a.l.l.c.a.r.a.Duration`](https://logging.apache.org/log4j/2.x/javadoc/log4j-core/org/apache/logging/log4j/core/appender/rolling/action/Duration) and replace it with `java

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil commented on issue #134: URL: https://github.com/apache/logging-log4net/issues/134#issuecomment-2025270759 @NicoCV can you test the code change from #135? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fix IndexOutOfRangeException in LogLog.LogReceived (#134) (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #135: URL: https://github.com/apache/logging-log4net/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
NicoCV commented on issue #134: URL: https://github.com/apache/logging-log4net/issues/134#issuecomment-2025367178 @FreeAndNil : First of all thanks for the really quick reaction and action! Unfortunatly it won't be possible for us to really test this. We've only seen this on production,

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil commented on issue #134: URL: https://github.com/apache/logging-log4net/issues/134#issuecomment-2025400384 @NicoCV I understand. The official release for this issue will be 3.0.0 expected in 2 months. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil closed issue #134: Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() URL: https://github.com/apache/logging-log4net/issues/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Remove Log4j API 3.x (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2411: URL: https://github.com/apache/logging-log4j2/pull/2411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Rebase Log4j Core 3.x on Log4j API 2.x (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2410: URL: https://github.com/apache/logging-log4j2/pull/2410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Scoped context (logging-log4j2)

2024-03-28 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2025463001 @ppkarwasz > The fact that there is only one logger per logger name is not set in stone (unlike in Logback). [LoggerRegistry](https://logging.apache.org/log4j/2.x/javadoc/lo

Re: [PR] Remove Log4j API 3.x (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on PR #2411: URL: https://github.com/apache/logging-log4j2/pull/2411#issuecomment-2025494481 My Github stats will never recover from the -50k lines hit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] Remove `o.a.l.l.c.a.r.a.Duration` class (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz opened a new pull request, #2426: URL: https://github.com/apache/logging-log4j2/pull/2426 This is the 3.x counterpart of the `o.a.l.l.c.a.r.a.Duration` deprecation in #2425. It also makes the `Clock` argument for the `IfLastModified` plugin compulsory. The argument is usual

[PR] Migrate `2.x` website to Antora (logging-log4j2)

2024-03-28 Thread via GitHub
vy opened a new pull request, #2427: URL: https://github.com/apache/logging-log4j2/pull/2427 This PR migrates the `asciidoctor-maven-plugin`-based current website in `2.x` to Antora *with several other improvements*. ### Rationale Developers love AsciiDoc, but `asciidoctor-mave

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2025622481 @FreeAndNil the ugliest adaptations I had to make with the new binary: * `Level?` on LoggingEvent and its internal data structure required adding a bunch of null checks, especial

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2025667615 @FreeAndNil I just tried setting LoggingEvent.Level to non-nullable and set to Level.All. Problem is that null is converted into different policies by different appenders (Debug, In

Re: [PR] Nullable: Eliminate nullable in one place, and clarify the meaning of null levels in doc comments (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #136: URL: https://github.com/apache/logging-log4net/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[PR] #124 LoggingEvent.Level not nullable (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil opened a new pull request, #137: URL: https://github.com/apache/logging-log4net/pull/137 #124 LoggingEvent.Level not nullable @erikmav what do you think about this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Merge `feature/log4j-sdk` into `main` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz opened a new pull request, #2428: URL: https://github.com/apache/logging-log4j2/pull/2428 This PR merges into the `main` development branch the enhancements from the following PRs: - [x] #2291 - [x] #2329 - [x] #2366 - [x] #2307 - [x] #2396 - [x] #2400 - [x

Re: [PR] #124 LoggingEvent.Level not nullable (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #137: URL: https://github.com/apache/logging-log4net/pull/137#issuecomment-2025957339 In the 2.x codebase a null level was handled as an allowed option, and some formatters use default behaviors on a null value (search for `level is null` across the codebase). IOW th

[PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav opened a new pull request, #138: URL: https://github.com/apache/logging-log4net/pull/138 Add BinaryFormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (#124). Commented out obsolete tag for FixFlags.Mdc

Re: [PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #138: URL: https://github.com/apache/logging-log4net/pull/138#issuecomment-2025976880 For #125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026031128 @jolly28, could you try with the latest version of `log4j-api` (i.e., `2.23.1`), please? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1543618080 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -649,45 +674,57 @@ public static Map partitionOnCommonPrefixes( * @return t

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1543694204 ## log4j-api/src/main/java/org/apache/logging/log4j/util/SystemPropertiesPropertySource.java: ## @@ -32,19 +34,32 @@ @ServiceProvider(value = PropertySource.class, r

Re: [PR] Remove `o.a.l.l.c.a.r.a.Duration` class (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2426: URL: https://github.com/apache/logging-log4j2/pull/2426#discussion_r1543719114 ## log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/IfLastModified.java: ## @@ -97,17 +91,24 @@ public String toString() { retu

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026137807 For context, this isssue is related to [this SO question](https://stackoverflow.com/q/78223383/11748454). -- This is an automated message from the Apache Git Service. To

Re: [PR] Deprecate `o.a.l.l.c.a.r.a.Duration` class for removal (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2425: URL: https://github.com/apache/logging-log4j2/pull/2425#discussion_r1543730541 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/convert/TypeConverters.java: ## @@ -224,11 +224,26 @@ public Double convert(final String s) {

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026143609 @jolly28, in [the SO question @ppkarwasz referenced](https://stackoverflow.com/q/78223383/11748454), you(?) state that issue persists with `2.23.1` too. If so, could you share the

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
jolly28 commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026715262 sure, @vy I am attaching the error stack trace I am getting while using the version 2.23.1. `SEVERE [main] org.apache.catalina.core.StandardContext.filterStart Excepti

[PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-tools]

2024-03-29 Thread via GitHub
dependabot[bot] opened a new pull request, #112: URL: https://github.com/apache/logging-log4j-tools/pull/112 Bumps commons-io:commons-io from 2.15.1 to 2.16.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-tools]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #112: URL: https://github.com/apache/logging-log4j-tools/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-tools]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #112: URL: https://github.com/apache/logging-log4j-tools/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 (logging-log4j2)

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #2429: URL: https://github.com/apache/logging-log4j2/pull/2429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544402118 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027242392 @rgoers, > It is worth repeating that resource Loggers should **NEVER** be added to the LoggerRegistry. Resource Loggers need to have the same lifetime as the resource. Logger

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027253194 @rgoers, Could you review my #2381 PR that introduces another `MessageFactory` to deal with Logback's throwable semantics? Maybe we should really consider creating a `log4

Re: [PR] Merge `feature/log4j-sdk` into `main` (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz merged PR #2428: URL: https://github.com/apache/logging-log4j2/pull/2428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1544546233 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -649,45 +674,57 @@ public static Map partitionOnCommonPrefixes( * @r

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1544550920 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -64,6 +68,8 @@ public final class PropertiesUtil { private static fina

Re: [PR] Deprecate `o.a.l.l.c.a.r.a.Duration` class for removal (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2425: URL: https://github.com/apache/logging-log4j2/pull/2425#discussion_r1544575754 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/convert/TypeConverters.java: ## @@ -224,11 +224,26 @@ public Double convert(final Stri

Re: [PR] Remove `o.a.l.l.c.a.r.a.Duration` class (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2426: URL: https://github.com/apache/logging-log4j2/pull/2426#discussion_r1544583487 ## log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/IfLastModified.java: ## @@ -97,17 +91,24 @@ public String toString() {

Re: [PR] Bump io.netty:netty-bom from 4.1.107.Final to 4.1.108.Final (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2397: URL: https://github.com/apache/logging-log4j2/pull/2397#issuecomment-2027339889 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2402: URL: https://github.com/apache/logging-log4j2/pull/2402#issuecomment-2027340194 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544596128 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544600596 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544606640 ## log4j-api/src/main/java/org/apache/logging/log4j/ResourceLogger.java: ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

<    1   2   3   4   5   6   7   8   9   10   >