erikmav commented on PR #137:
URL: https://github.com/apache/logging-log4net/pull/137#issuecomment-2025957339
In the 2.x codebase a null level was handled as an allowed option, and some
formatters use default behaviors on a null value (search for `level is null`
across the codebase). IOW this is probably a back compat problem where we might
break people. Maybe that's OK in v3... which means we need `if (level is null)
{ throw new ArgumentNullException(nameof(level)); }` anywhere we're receiving a
level from the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
