FreeAndNil commented on code in PR #131:
URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541538986
##########
src/log4net/ILog.cs:
##########
@@ -216,7 +216,7 @@ public interface ILog : ILoggerWrapper
/// </remarks>
/// <seealso cref="M:Debug(object)"/>
/// <seealso cref="IsDebugEnabled"/>
- void DebugFormat(IFormatProvider provider, string format, params object[]
args);
+ void DebugFormat(IFormatProvider? provider, string format, params object[]
args);
Review Comment:
Good idea.
We also have a lot of nullable aware consumers for testing.
Do you need the preview nuget package on nuget.org or can you host it
yourself (for testing)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
