erikmav commented on code in PR #131:
URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541420446
##########
src/log4net/Appender/BufferingAppenderSkeleton.cs:
##########
@@ -437,7 +437,7 @@ protected override void Append(LoggingEvent loggingEvent)
loggingEvent.Fix = Fix;
// Add to the buffer, returns the event discarded from the buffer if
there is no space remaining after the append
- LoggingEvent discardedLoggingEvent = m_cb.Append(loggingEvent);
+ LoggingEvent? discardedLoggingEvent = m_cb.Append(loggingEvent);
Review Comment:
Leaving this one in place, making that change invalidates line 455
`discardedLoggingEvent = null` since an "is type variableName" does not allow
nullable for variableName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
