ppkarwasz commented on code in PR #2396:
URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540657373
##########
log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/Tags.java:
##########
@@ -14,25 +14,20 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.logging.log4j.core.annotation;
-
-import java.lang.annotation.Documented;
-import java.lang.annotation.ElementType;
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-import java.lang.annotation.Target;
-import org.apache.logging.log4j.core.impl.Log4jPropertyKey;
-import org.apache.logging.log4j.plugins.condition.Conditional;
+package org.apache.logging.log4j.test.junit;
/**
- * Checks if a Log4j property is present or matches a specific non-empty value.
+ * A set of tags for JUnit 5 tests.
*/
-@Retention(RetentionPolicy.RUNTIME)
-@Target({ElementType.TYPE, ElementType.ANNOTATION_TYPE, ElementType.METHOD})
-@Documented
-@Conditional(OnPropertyKeyCondition.class)
-public @interface ConditionalOnPropertyKey {
- Log4jPropertyKey key();
+public final class Tags {
+
+ /**
+ * Marks tests that don't modify the global environment.
+ * <p>
+ * These tests can safely be run in parallel.
+ * </p>
+ */
+ public static final String PARALLEL = "parallel";
Review Comment:
`THREAD_SAFE` sounds good.
As you pointed out earlier, there is not point in tagging the tests, if we
don't use those tags. I created #2417 to run the best tests in a separate JUnit
execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
