hyunw9 opened a new pull request, #3617:
URL: https://github.com/apache/logging-log4j2/pull/3617
Description
Corrected a typo in error message for invalid conversion pattern in LogLog.
Changed patterrn → pattern for better readability.
found typo :
![화면 캡처 2025-04-16
075649]
FreeAndNil opened a new pull request, #238:
URL: https://github.com/apache/logging-log4net/pull/238
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045351878
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045351528
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045350948
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045350487
##
src/site/antora/antora.yml:
##
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2045316770
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045319737
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2045316770
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045307641
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045307641
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045302745
##
src/site/antora/antora.yml:
##
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045299948
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
- h
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045298863
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
- h
FreeAndNil commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045298557
##
antora-playbook.yaml:
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045294226
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
- h
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045293724
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
- h
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045290659
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
- h
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045290332
##
pom.xml:
##
@@ -39,157 +58,131 @@
https://mail-archives.apache.org/mod_mbox/logging-commits/
-
-
- Apache License, Version 2.0
- h
vy commented on code in PR #210:
URL: https://github.com/apache/logging-log4net/pull/210#discussion_r2045288723
##
antora-playbook.yaml:
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTI
ppkarwasz commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2045176799
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled":
ppkarwasz closed pull request #28: Bump
apache/logging-parent/.github/workflows/deploy-site-reusable.yaml@rel/11.3.0
from 11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-jmx-gui/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
ppkarwasz commented on code in PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#discussion_r2044458768
##
.github/workflows/add-dependabot-changelog.yaml:
##
Review Comment:
Yes, it should, be we need to test it first. The hard part is probably to
trigger
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044567613
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
ppkarwasz closed pull request #172: Bump
apache/logging-parent/.github/workflows/merge-dependabot-reusable.yaml@rel/11.3.0
from 11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-tools/pull/172
--
This is an automated message from the Apache Git Service.
To respond to the message,
ppkarwasz closed pull request #106: Bump
apache/logging-parent/.github/workflows/build-reusable.yaml@rel/11.3.0 from
11.3.0 to 12.0.0
URL: https://github.com/apache/logging-log4j-kotlin/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
ppkarwasz merged PR #3602:
URL: https://github.com/apache/logging-log4j2/pull/3602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
vy commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2043956202
##
github.json:
##
Review Comment:
What is this and why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message,
ppkarwasz closed issue #3601: Fix `SEI MET07-J` violations
URL: https://github.com/apache/logging-log4j2/issues/3601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
ppkarwasz commented on PR #3602:
URL: https://github.com/apache/logging-log4j2/pull/3602#issuecomment-2804135956
@vy, thanks! :100:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
vy commented on issue #3604:
URL:
https://github.com/apache/logging-log4j2/issues/3604#issuecomment-2804252632
We had enabled Scorecards, and it helped with
1. Creating a maintenance burden (Remember how many times we needed to fix
its CI workflow?)
2. Bringing literally no value
ppkarwasz opened a new pull request, #3616:
URL: https://github.com/apache/logging-log4j2/pull/3616
Due to limitations in the number of GitHub Sponsors buttons (there can be
only up to 4 buttons), part of the team is ignored.
This replaces the buttons with our "Sponsorship" page and a
ppkarwasz commented on PR #367:
URL: https://github.com/apache/logging-parent/pull/367#issuecomment-280480
I modified the way `node_modules` are cached: since running a second
`actions/checkout` in the same workflow deletes `node_modules`, the folder must
be restored at the end of the w
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044531747
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
ppkarwasz commented on PR #3580:
URL: https://github.com/apache/logging-log4j2/pull/3580#issuecomment-2805024558
Fixed in #3616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ppkarwasz merged PR #310:
URL: https://github.com/apache/logging-log4j-samples/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044531747
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
ppkarwasz commented on PR #3228:
URL: https://github.com/apache/logging-log4j2/pull/3228#issuecomment-2805698294
> will this have any [backward compatibility] implications on the fat JAR
users?
I am not sure what implications are you thinking about. Yes, their fat JARs
will be a coup
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044531747
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044567613
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": tr
github-actions[bot] merged PR #315:
URL: https://github.com/apache/logging-log4j-samples/pull/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
ppkarwasz commented on PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2804944691
Currently all Dependabot workflows fail (see [job
40576197611](https://github.com/apache/logging-log4j2/actions/runs/14467978596/job/40576197611)
and the new commit does not trig
ppkarwasz commented on issue #3604:
URL:
https://github.com/apache/logging-log4j2/issues/3604#issuecomment-2804927362
> > we have more control on what the public sees
>
> Do you imply that OSSF is manipulating the scores? Or, we can manipulate
the scores as we see fit?
No, but
vy commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044010077
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -37,8 +42,9 @@
}
},
"logging.googleapis.com/insertId": {
-"$resolver": "counter"
ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044317642
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -37,8 +42,9 @@
}
},
"logging.googleapis.com/insertId": {
-"$resolver": "cou
vy commented on code in PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#discussion_r2044019381
##
.github/workflows/add-dependabot-changelog.yaml:
##
Review Comment:
Shouldn't this be a reusable in `logging-parent`? Does every project need to
roll out the
ppkarwasz commented on PR #379:
URL: https://github.com/apache/logging-parent/pull/379#issuecomment-2804521321
Since changes to reusable workflows are half of the PRs in this repository,
I find that this is not just a convenience for maintainers:
- A PR can be approved by mistake, bec
vy commented on PR #3580:
URL: https://github.com/apache/logging-log4j2/pull/3580#issuecomment-2804618550
@ppkarwasz, putting me aside, even @rgoers is excluded. Would you mind
submitting a PR reverting this change, please?
--
This is an automated message from the Apache Git Service.
To r
ppkarwasz commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2044218634
##
github.json:
##
Review Comment:
Nice catch! :100:
This was a temporary file with `${{ github.toString() }}` I created to see
if the branch name o
ppkarwasz opened a new pull request, #320:
URL: https://github.com/apache/logging-log4j-samples/pull/320
This is an implementation of the [PMC vote in
`dev@logging`](https://lists.apache.org/thread/8ffdw1zqrvwrsdr0ng0m2rgtdnpzg4hk).
I didn't add any required checks, since:
- Any test
ppkarwasz commented on PR #315:
URL:
https://github.com/apache/logging-log4j-samples/pull/315#issuecomment-2804525111
@dependabot rebase, the build should succeed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ppkarwasz merged PR #314:
URL: https://github.com/apache/logging-log4j-samples/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
ppkarwasz merged PR #313:
URL: https://github.com/apache/logging-log4j-samples/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
vy commented on PR #379:
URL: https://github.com/apache/logging-parent/pull/379#issuecomment-2804224837
Although I can see the advantage (i.e., a PR touching to reusable workflows
will directly get employed, instead of the one at `main`), I'm not keen on with
this change for the following r
ppkarwasz closed issue #3601: Fix `SEI MET07-J` violations
URL: https://github.com/apache/logging-log4j2/issues/3601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
vy commented on PR #3228:
URL: https://github.com/apache/logging-log4j2/pull/3228#issuecomment-2804313789
@ppkarwasz, will this have any [backward compatibility] implications on the
fat JAR users?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
vy commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044006120
##
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": true,
-
57 matches
Mail list logo
