vy commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044010077
##########
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##########
@@ -37,8 +42,9 @@
}
},
"logging.googleapis.com/insertId": {
- "$resolver": "counter",
- "stringified": true
+ "$resolver": "pattern",
+ "pattern": "%uuid{TIME}",
+ "stackTraceEnabled": false
Review Comment:
> `counter` produces duplicate IDs for different thread of the same
application.
@ViliusS, what do you mean by this? Each JTL layout instance has its own
`AtomicLong` (or `AtomicBigInteger`) counter. If you end up seeing the same
counter value, it sounds like a severe bug to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
