[GitHub] [logging-log4j2] wx930910 commented on pull request #584: LOG4J2-3164: Refactor StoringStatusListener to improve test logic

wx930910 commented on pull request #584: URL: https://github.com/apache/logging-log4j2/pull/584#issuecomment-924494400 @vy Thanks for your comments! Make sence to me, I changed the code corresponding to your advice :+1: -- This is an automated message from the Apache Git Service. To res

[jira] [Updated] (LOGCXX-528) log4cxx fails to build on Centos 7.6 / g++ 4.8.5 / Boost 1.53

[ https://issues.apache.org/jira/browse/LOGCXX-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Middleton updated LOGCXX-528: Fix Version/s: 0.12.1 > log4cxx fails to build on Centos 7.6 / g++ 4.8.5 / Boost 1.53 > ---

[GitHub] [logging-log4j2] carterkozak commented on pull request #573: Reduce PatternLayout branching

carterkozak commented on pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-924387654 > imagine the results may depend on the distinct number and shape of formatter patterns used in an application, as that may push C2 to optimize differently for monomor

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #573: Reduce PatternLayout branching

carterkozak commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713391653 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java ## @@ -88,9 +88,10 @@ public boolean requi

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #573: Reduce PatternLayout branching

carterkozak commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713390780 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/impl/LogEventFactory.java ## @@ -28,8 +28,21 @@ /** * */ -public inter

[jira] [Assigned] (LOG4J2-3164) Refactor StoringStatusListener to improve test logic

[ https://issues.apache.org/jira/browse/LOG4J2-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici reassigned LOG4J2-3164: - Assignee: Volkan Yazici > Refactor StoringStatusListener to improve test logic > --

[GitHub] [logging-log4j2] vy commented on pull request #584: LOG4J2-3164: Refactor StoringStatusListener to improve test logic

vy commented on pull request #584: URL: https://github.com/apache/logging-log4j2/pull/584#issuecomment-924330636 Thanks so much for the contribution @wx930910! Mocking is definitely a better approach, since it allows (backward-compatible) evolution of `StatusListener` without breaking test

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #573: Reduce PatternLayout branching

carterkozak commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713214204 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Lic

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713151635 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java ## @@ -669,20 +668,20 @@ private int finalizeCo

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713156919 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713156919 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #573: Reduce PatternLayout branching

carterkozak commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713155432 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Lic

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713155032 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #573: Reduce PatternLayout branching

carterkozak commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713154918 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java ## @@ -669,20 +668,20 @@ private int finalizeCon

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713154271 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713153477 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [logging-log4j2] carterkozak commented on pull request #573: Reduce PatternLayout branching

carterkozak commented on pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-924095311 Sorry, Ralph. I've updated this branch with a fix. I'm going to PR something into the release branch separately to improve messaging/behavior in that case because it's

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #573: Reduce PatternLayout branching

garydgregory commented on a change in pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713152109 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [logging-log4j2] rgoers commented on pull request #573: Reduce PatternLayout branching

rgoers commented on pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-923720165 I cloned your repo and checked out this branch. When I run the build all the RollingFileAppender tests fail and RollingAppenderDeleteScriptFri13thTest is permanently stuck i