Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 20:34 +0100, Patrick McHardy wrote:
Looking at it again, I think you should not change the existing return
code but just use NET_XMIT_BYPASS for the TC_ACT_SHOT (TC_POLICE_SHOT)
case. Otherwise you will also return it if the packet couldn't be
class
On Sun, 2006-08-01 at 20:34 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
> > Maybe no need to worry about both situations for now, i will resubmit
> > the patch without worrying about NET_XMIT_DROP.
>
> Looking at it again, I think you should not change the existing return
> code but j
Jamal Hadi Salim wrote:
Maybe no need to worry about both situations for now, i will resubmit
the patch without worrying about NET_XMIT_DROP.
Looking at it again, I think you should not change the existing return
code but just use NET_XMIT_BYPASS for the TC_ACT_SHOT (TC_POLICE_SHOT)
case. Othe
On Sun, 2006-08-01 at 20:01 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
[..]
> > I could get rid of that - but there is one dilemma:
> > There are really two reasons to ask the qdisc to drop
> > 1) policy said so
> > 2) an error happened
>
> In both cases NET_XMIT_DROP can not happen.
Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 19:35 +0100, Patrick McHardy wrote:
Jamal Hadi Salim wrote:
[..]
if (cl == NULL) {
- if (ret == NET_XMIT_DROP)
+ if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
No objections to the new mapping, but the
On Sun, 2006-08-01 at 19:35 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
[..]
> > if (cl == NULL) {
> > - if (ret == NET_XMIT_DROP)
> > + if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
>
> No objections to the new mapping, but the NET_XMIT_DROP handling
> he
Jamal Hadi Salim wrote:
The little discussion going on reminds me of this other patch i was
sitting on. Patrick made the last changes to this area.
Dave please apply if ACK from Patrick.
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -257,7 +257,7 @@ cbq_classify(struct sk_buff *skb, str
