On Sun, 2006-08-01 at 20:01 +0100, Patrick McHardy wrote: > Jamal Hadi Salim wrote: [..] > > I could get rid of that - but there is one dilemma: > > There are really two reasons to ask the qdisc to drop > > 1) policy said so > > 2) an error happened > > In both cases NET_XMIT_DROP can not happen. The only place > where "ret" is set is in cbq_classify (in case of CBQ), and > it only uses NET_XMIT_BYPASS (with your patch) or > NET_XMIT_SUCCESS.
Maybe no need to worry about both situations for now, i will resubmit the patch without worrying about NET_XMIT_DROP. But imagine that mirred action is applied to a device at the moment when the device is down you want the reaction to that to be different from when mirred steals the packet because the device is up. I think at some point a big surgery on the return path and associated error path is needed. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
