Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 19:35 +0100, Patrick McHardy wrote:
Jamal Hadi Salim wrote:
[..]
if (cl == NULL) {
- if (ret == NET_XMIT_DROP)
+ if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
No objections to the new mapping, but the NET_XMIT_DROP handling
here and in the other qdiscs looks unneccessary, AFAICT it can't
happen anymore with your change.
I could get rid of that - but there is one dilemma:
There are really two reasons to ask the qdisc to drop
1) policy said so
2) an error happened
In both cases NET_XMIT_DROP can not happen. The only place
where "ret" is set is in cbq_classify (in case of CBQ), and
it only uses NET_XMIT_BYPASS (with your patch) or
NET_XMIT_SUCCESS.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
