Jamal Hadi Salim wrote:
The little discussion going on reminds me of this other patch i was sitting on. Patrick made the last changes to this area. Dave please apply if ACK from Patrick.--- a/net/sched/sch_cbq.c +++ b/net/sched/sch_cbq.c @@ -257,7 +257,7 @@ cbq_classify(struct sk_buff *skb, struct (cl = cbq_class_lookup(q, prio)) != NULL) return cl;- *qerr = NET_XMIT_DROP;+ *qerr = NET_XMIT_BYPASS; for (;;) { int result = 0; defmap = head->defaults;@@ -413,7 +413,7 @@ cbq_enqueue(struct sk_buff *skb, struct q->rx_class = cl;#endif if (cl == NULL) { - if (ret == NET_XMIT_DROP) + if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
No objections to the new mapping, but the NET_XMIT_DROP handling here and in the other qdiscs looks unneccessary, AFAICT it can't happen anymore with your change. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
