On Sun, 2006-08-01 at 19:35 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
[..]
> > if (cl == NULL) {
> > - if (ret == NET_XMIT_DROP)
> > + if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
>
> No objections to the new mapping, but the NET_XMIT_DROP handling
> here and in the other qdiscs looks unneccessary, AFAICT it can't
> happen anymore with your change.
I could get rid of that - but there is one dilemma:
There are really two reasons to ask the qdisc to drop
1) policy said so
2) an error happened
There is no way to differentiate the two at the moment - and i was
hopping at some point to scrutinize the code closely (since it is a
subtle change). Actually:
#1 could probably use NET_XMIT_POLICED but that requires a lot more
changes at the qdiscs and a lot more confusion to TCP and upper layers;
hence the reason i kept both codes.
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
