Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 16:32:44 +0200 you wrote:
> This patchset adds software match support and offload of flower
> match ct_state reply flag (+/-rpl).
>
> The first patch adds the definition for the flag and match to flowe
On Thu, 28 Jan 2021 17:11:00 -0800 Mat Martineau wrote:
> + if (entry->addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL) {
> + addr_max = READ_ONCE(pernet->add_addr_signal_max);
> + WRITE_ONCE(pernet->add_addr_signal_max, addr_max + 1);
> + }
This is an odd construct.
READ_O
On Thu, 28 Jan 2021 17:11:00 -0800 Mat Martineau wrote:
> spin_lock_bh(&pernet->lock);
> - rcv_addrs = pernet->add_addr_accept_max;
> + rcv_addrs = READ_ONCE(pernet->add_addr_accept_max);
Oh, this reader is also under the lock, what's the concurrency issue
you speak of?
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 29 Jan 2021 23:53:50 + you wrote:
> AF_RXRPC sockets use UDP ports in encap mode. This causes socket and dst
> from an incoming packet to get stolen and attached to the UDP socket from
> whence it is leaked when tha
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 29 Jan 2021 02:59:58 +0200 you wrote:
> From: Vladimir Oltean
>
> Changes in v8:
> - Make tagging driver module reference counting work per DSA switch tree
> instead of per CPU port, to be compatible with the t
On Fri, 29 Jan 2021 13:55:24 +0200 Nikolay Aleksandrov wrote:
> On 29/01/2021 13:51, Nikolay Aleksandrov wrote:
> > From: Nikolay Aleksandrov
> >
> > Hi,
> > As recently discussed[1] we should stop extending the bridge sysfs
> > support for new options and move to using netlink only, so patch 01
On Thu, 28 Jan 2021 11:38:34 -0800 Ronak Doshi wrote:
> buf_info structures in RX & TX queues are private driver data that
> do not need to be visible to the device. Although there is physical
> address and length in the queue descriptor that points to these
> structures, their layout is not stand
On Thu, 28 Jan 2021 12:00:38 -0800 Randy Dunlap wrote:
> Signed-off-by: Randy Dunlap
nit: careful with the tags in replies to patches, patchwork will add
them onto the patch you're replying to
On Wed, 27 Jan 2021 20:11:01 + Alexander Lobakin wrote:
> The function only tests for page->index, so its argument should be
> const.
>
> Signed-off-by: Alexander Lobakin
> ---
> include/linux/mm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm.h b
From: Yevgeny Kliteynik
Add STEv1 match logic to a new file.
This file will be used for HW specific STEv1.
Signed-off-by: Alex Vesker
Signed-off-by: Yevgeny Kliteynik
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../mellanox/mlx5/core/steering/dr_
On Thu, 28 Jan 2021 15:19:12 +0100 Loic Poulain wrote:
> Hi Jakub,
>
> As requested, here is the pull-request based on mhi-net-immutable +
> mhi-net patches.
Pulled, thanks!
From: Yevgeny Kliteynik
Till now the code assumed that need to copy reduced size of the
ste because the rest is the mask part which shouldn't be changed.
This is not true for all types of HW (like STEv1).
Take all 64B from the new STE and write them in the replaced STE place.
This change will mak
From: Saeed Mahameed
Hi Jakub, Dave.
This series adds support for ConnectX-6DX Software steering.
For more information please see tag log below.
Please pull and let me know if there is any problem.
Thanks,
Saeed.
---
The following changes since commit 46eb3c108fe1744d0a6abfda69ef8c1d4f0e92d4:
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 18:32:55 +0100 you wrote:
> Previously a temporary tasklet structure was initialized on the stack
> using DECLARE_TASKLET_OLD() and then copied over and modified. Nothing
> else in the kernel seems to u
On Fri, 29 Jan 2021 17:44:12 + Pierre Cheynier wrote:
> Dear list,
>
> I noticed this assertion error recently after upgrading to 5.10.x (latest
> trial being 5.10.11).
> Coming indirectly with my usage of the vxlan module, the assertion output
> will probably give you the information requir
Figured I would poke someone to add this patch to the stable queue - I
don't see it in
https://patchwork.kernel.org/bundle/netdev/stable/?state=* right now.
This patch is reported to fix a severe upload speed regression in many
Intel wireless adapters existing since kernel 5.9, as described in
http
In order to send sampled packets to userspace, NIC driver calls
psample api directly. But it creates a hard dependency on module
psample. Introduce psample_ops to remove the hard dependency.
It is initialized when psample module is loaded and set to NULL
when the module is unloaded.
Reported-by: k
On Thu, Jan 28, 2021 at 12:11:05PM +0530, Prasanna Vengateshan wrote:
> + spi-max-frequency:
> +maximum: 5000
And it actually works at 50 MHz? Cool.
> +
> + reset-gpios:
> +description: Optional gpio specifier for a reset line
> +maxItems: 1
> +
> +required:
> + - compatible
>
On Wed, 27 Jan 2021 18:01:17 +0100 Loic Poulain wrote:
> MBIM has initially been specified by USB-IF for transporting data (IP)
> between a modem and a host over USB. However some modern modems also
> support MBIM over PCIe (via MHI). In the same way as QMAP(rmnet), it
> allows to aggregate IP pack
On Fri, Jan 29, 2021 at 8:01 PM Jakub Kicinski wrote:
>
> On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote:
> > When device side MTU is larger than host side MRU, the packets
> > (typically rmnet packets) are split over multiple MHI transfers.
> > In that case, fragments must be re-aggregated
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 04:33:02 -0800 you wrote:
> From: Menglong Dong
>
> It's better make 'pkt_sk()' inline here, as non-inline function
> shouldn't occur in headers. Besides, this function is simple
> enough to be inline.
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
> implement private channel OPs
>
> On Wed, Jan 27, 2021 at 07:16:41PM -0400, Jason Gunthorpe wrote:
> > On Wed, Jan 27, 2021 at 10:17:56PM +, Saleem, Shiraz wrote:
> >
> > > Even with another core PCI driver, there stil
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
> implement private channel OPs
>
> On Wed, Jan 27, 2021 at 12:42:09AM +, Saleem, Shiraz wrote:
>
> > > It does, the PCI driver is not supposed to spawn any aux devices for
> > > RDMA at all if RDMA is disabled.
> > >
>
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
> implement private channel OPs
>
> On Fri, Jan 22, 2021 at 05:48:12PM -0600, Shiraz Saleem wrote:
>
> > +static int irdma_probe(struct auxiliary_device *aux_dev,
> > + const struct auxiliary_device_id *id)
Move the dma_rmb() between pending_scrq() and ibmvnic_next_scrq()
into the end of pending_scrq() to save the duplicated code since
this dma_rmb will be used 3 times.
Signed-off-by: Lijun Pan
Acked-by: Thomas Falcon
---
drivers/net/ethernet/ibm/ibmvnic.c | 30 +++---
1 fi
> Subject: Re: [PATCH 20/22] RDMA/irdma: Add ABI definitions
>
> On Fri, Jan 22, 2021 at 05:48:25PM -0600, Shiraz Saleem wrote:
> > From: Mustafa Ismail
> >
> > Add ABI definitions for irdma.
> >
> > Signed-off-by: Mustafa Ismail
> > Signed-off-by: Shiraz Saleem
> > include/uapi/rdma/irdma-abi.
On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote:
> When device side MTU is larger than host side MRU, the packets
> (typically rmnet packets) are split over multiple MHI transfers.
> In that case, fragments must be re-aggregated to recover the packet
> before forwarding to upper layer.
>
> A
On Fri, Jan 29, 2021 at 03:42:05PM -0800, Vinicius Costa Gomes wrote:
> >> But as I said above, perhaps this should be handled in a per-driver
> >> way. I will remove this from taprio.
> >>
> >> I think removing this check/limitation from taprio should solve the
> >> second part of your question, r
Vladimir Oltean writes:
> On Fri, Jan 22, 2021 at 02:44:45PM -0800, Vinicius Costa Gomes wrote:
>> This is still an RFC because two main reasons, I want to confirm that
>> this approach (per-queue settings via qdiscs, device settings via
>> ethtool) looks good, even though there aren't much more
On 1/29/2021 12:23 PM, Willem de Bruijn wrote:
> On Thu, Jan 28, 2021 at 4:45 PM Tony Nguyen
> wrote:
>>
>> From: Aleksandr Loktionov
>>
>> This reverts commit 2ad1274fa35ace5c6360762ba48d33b63da2396c
>>
>> VF queues were not brought up when PF was brought up after being
>> downed if the VF d
On 1/29/21 4:50 PM, John Fastabend wrote:
Jesper Dangaard Brouer wrote:
On Thu, 28 Jan 2021 22:51:23 -0800
John Fastabend wrote:
Jesper Dangaard Brouer wrote:
This BPF-helper bpf_check_mtu() works for both XDP and TC-BPF programs.
The SKB object is complex and the skb->len value (accessible
AF_RXRPC sockets use UDP ports in encap mode. This causes socket and dst
from an incoming packet to get stolen and attached to the UDP socket from
whence it is leaked when that socket is closed.
When a network namespace is removed, the wait for dst records to be cleaned
up happens before the clea
> I'd encourage anyone thinking about "using OOB" to read
> https://tools.ietf.org/html/rfc6093 first. Basically, TCP does not
> actually provide an OOB mechanism, and frankly Unix sockets shouldn't
> try either.
OOB data maps much better onto ISO transport 'expedited data'
than anything in a byt
On Fri, Jan 29, 2021 at 03:00:06AM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Currently DSA exposes the following sysfs:
> $ cat /sys/class/net/eno2/dsa/tagging
> ocelot
>
> which is a read-only device attribute, introduced in the kernel as
> commit 98cdb4807123 ("net: dsa: Expose
Vladimir Oltean writes:
> On Fri, Jan 29, 2021 at 01:13:24PM -0800, Vinicius Costa Gomes wrote:
>> > Secondly, why should at least one queue be preemptible? What's wrong
>> > with frame preemption being triggered by a tc-taprio window smaller than
>> > the packet size? This can happen regardless
On Fri, Jan 22, 2021 at 02:44:45PM -0800, Vinicius Costa Gomes wrote:
> This is still an RFC because two main reasons, I want to confirm that
> this approach (per-queue settings via qdiscs, device settings via
> ethtool) looks good, even though there aren't much more options left ;-)
I don't want
UDP/IP header of UDP GROed frag_skbs are not updated even after NAT
forwarding. Only the header of head_skb from ip_finish_output_gso ->
skb_gso_segment is updated but following frag_skbs are not updated.
A call path skb_mac_gso_segment -> inet_gso_segment ->
udp4_ufo_fragment -> __udp_gso_segment
On Fri, Jan 29, 2021 at 4:02 AM Alexander Ovechkin wrote:
>
> Commit e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge
> helpers")
> introduced qdisc tree flush/purge helpers, but erroneously used flush helper
> instead of purge helper in qdisc_replace function.
> This issue was
On Fri, Jan 29, 2021 at 01:13:24PM -0800, Vinicius Costa Gomes wrote:
> > Secondly, why should at least one queue be preemptible? What's wrong
> > with frame preemption being triggered by a tc-taprio window smaller than
> > the packet size? This can happen regardless of traffic class.
>
> It's the
On Fri, Jan 29, 2021 at 01:27:28PM -0800, Vinicius Costa Gomes wrote:
> >> +static int igc_ethtool_set_preempt(struct net_device *netdev,
> >> + struct ethtool_fp *fpcmd,
> >> + struct netlink_ext_ack *extack)
> >> +{
> >> + struct igc_adapte
Jakub Kicinski writes:
>> > First I'm interested in the means: why check for preempt == U32_MAX when
>> > you determine that all traffic classes are preemptible? What if less
>> > than 32 traffic classes are used by the netdev? The check will be
>> > bypassed, won't it?
>>
>> Good catch :-)
>>
On Fri, Jan 29, 2021 at 10:00 AM Jakub Kicinski wrote:
>
> On Thu, 28 Jan 2021 21:47:04 -0800 Cong Wang wrote:
> > On Thu, Jan 28, 2021 at 9:21 PM Jakub Kicinski wrote:
> > > On Thu, 28 Jan 2021 21:08:05 -0800 Cong Wang wrote:
> > > > On Thu, Jan 28, 2021 at 12:55 PM Jakub Kicinski wrote:
> > >
On Fri, Jan 29, 2021 at 6:08 PM Willem de Bruijn
wrote:
>
> Okay. I found it a bit hard to parse how much true code change was
> mixed in with just reindenting existing code. If a lot, then no need
> to split of the code refactor.
Thank you. The code is quite hard to review in patch format.
Proba
On Fri, Jan 29, 2021 at 6:03 PM Sven Van Asbroeck wrote:
>
> Hoi Willem, thanks a lot for reviewing this patch, much appreciated !!
>
> On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn
> wrote:
> >
> > > +static struct sk_buff *
> > > +lan743x_rx_trim_skb(struct sk_buff *skb, int frame_length)
>
On Fri, Jan 29, 2021 at 2:29 AM Simon Horman wrote:
> +/**
> + * psched_ratecfg_precompute__() - Pre-compute values for reciprocal division
> + * @rate: Rate to compute reciprocal division values of
> + * @mult: Multiplier for reciprocal division
> + * @shift: Shift for reciprocal division
>
Hoi Willem, thanks a lot for reviewing this patch, much appreciated !!
On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn
wrote:
>
> > +static struct sk_buff *
> > +lan743x_rx_trim_skb(struct sk_buff *skb, int frame_length)
> > +{
> > + if (skb_linearize(skb)) {
>
> Is this needed? That will
Hi Andrew, thank you so much for looking at this patch !
On Fri, Jan 29, 2021 at 3:36 PM Andrew Lunn wrote:
>
> So this patch appears to contain two different changes
> 1) You only allocate a receive buffer as big as the MTU plus overheads
> 2) You change the cache operations to operate on the re
On Fri, Jan 29, 2021 at 5:01 PM Jakub Kicinski wrote:
>
> You may need to rebase to see this:
>
> drivers/net/ethernet/microchip/lan743x_main.c:2123:41: warning: restricted
> __le32 degrades to integer
Good catch. The problem goes away with the next commit in the set.
This is probably because I
dev->hard_header_len for tunnel interface is set only when header_ops
are set too and already contains full overhead of any tunnel encapsulation.
That's why there is not need to use this overhead twice in mtu calc.
Fixes: fdafed459998 ("ip_gre: set dev->hard_header_len and dev->needed_headroom
pr
On Fri, Jan 29, 2021 at 2:56 PM Sven Van Asbroeck wrote:
>
> From: Sven Van Asbroeck
>
> Multi-buffer packets enable us to use rx ring buffers smaller than
> the mtu. This will allow us to change the mtu on-the-fly, without
> having to stop the network interface in order to re-size the rx
> ring
On Fri, 29 Jan 2021 10:29:29 -0500 Willem de Bruijn wrote:
> On Fri, Jan 29, 2021 at 9:45 AM Vadim Fedorenko wrote:
> >
> > dev->hard_header_len for tunnel interface is set only when header_ops
> > are set too and already contains full overhead of any tunnel encapsulation.
> > That's why there is
Split ndo_xdp_xmit and ndo_start_xmit use cases in veth_xdp_rcv routine
in order to alloc skbs in bulk for XDP_PASS verdict.
Introduce xdp_alloc_skb_bulk utility routine to alloc skb bulk list.
The proposed approach has been tested in the following scenario:
eth (ixgbe) --> XDP_REDIRECT --> veth0
On Fri, 29 Jan 2021 14:52:35 -0500 Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck
>
> The buffers in the lan743x driver's receive ring are always 9K,
> even when the largest packet that can be received (the mtu) is
> much smaller. This performs particularly badly on cpu archs
> without dma ca
On Fri, 29 Jan 2021 01:15:56 +0100 Daniel Borkmann wrote:
> 1) Fix two copy_{from,to}_user() warn_on_once splats for BPF cgroup getsockopt
>infra when user space is trying to race against optlen, from Loris Reiff.
>
> 2) Fix a missing fput() in BPF inode storage map update helper, from Pan Bia
On 1/29/21 1:18 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote:
On 1/29/21 12:18 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote:
The code does not care about the size of data -- All it does is that if
MSG_OOB is set it will delive
On Fri, 29 Jan 2021 13:13:24 -0800 Vinicius Costa Gomes wrote:
> Vladimir Oltean writes:
>
> > On Fri, Jan 22, 2021 at 02:44:47PM -0800, Vinicius Costa Gomes wrote:
> >> + /* It's valid to enable frame preemption without any kind of
> >> + * offloading being enabled, so keep it separated.
>
On Thu, 28 Jan 2021 09:45:43 +0800 Chris Mi wrote:
> In order to send sampled packets to userspace, NIC driver calls
> psample api directly. But it creates a hard dependency on module
> psample. Introduce psample_ops to remove the hard dependency.
> It is initialized when psample module is loaded a
On Jan 29, Lorenzo Bianconi wrote:
> On Jan 29, Jesper Dangaard Brouer wrote:
> > On Fri, 29 Jan 2021 17:02:16 +0100
> > Jesper Dangaard Brouer wrote:
> >
> > > > + for (i = 0; i < n_skb; i++) {
> > > > + struct sk_buff *skb = skbs[i];
> > > > +
> > > > + memset(
On Jan 29, Jesper Dangaard Brouer wrote:
> On Fri, 29 Jan 2021 17:02:16 +0100
> Jesper Dangaard Brouer wrote:
>
> > > + for (i = 0; i < n_skb; i++) {
> > > + struct sk_buff *skb = skbs[i];
> > > +
> > > + memset(skb, 0, offsetof(struct sk_buff, tail));
> >
> > It is very subtle
On Fri, 29 Jan 2021 12:44:59 -0800 Saeed Mahameed wrote:
> On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote:
> > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
> > > Instead of discussing it several days, maybe it's better to review
> > > current patch, so that we can move forward :)
> On 2021/01/29 4:41, Lorenzo Bianconi wrote:
> > Split ndo_xdp_xmit and ndo_start_xmit use cases in veth_xdp_rcv routine
> > in order to alloc skbs in bulk for XDP_PASS verdict.
> > Introduce xdp_alloc_skb_bulk utility routine to alloc skb bulk list.
> > The proposed approach has been tested in th
On Thu, Jan 28, 2021 at 7:44 PM Tony Nguyen wrote:
>
> This series contains updates to ice driver only.
>
> Jake adds devlink reporting of security revision fields associated with
> 'fw.undi' and 'fw.mgmt'. Also implements support for displaying and
> updating the minimum security revision fields
On Fri, Jan 29, 2021 at 4:32 PM Jacob Keller wrote:
>
>
>
> On 1/29/2021 1:04 PM, Willem de Bruijn wrote:
> > On Fri, Jan 29, 2021 at 4:01 PM Willem de Bruijn
> > wrote:
> >>
> >> On Thu, Jan 28, 2021 at 7:46 PM Tony Nguyen
> >> wrote:
> >>>
> >>> From: Jacob Keller
> >>>
> >>> The ice flash c
On Fri, Jan 29, 2021 at 01:18:20PM -0800, Jakub Kicinski wrote:
> On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote:
> > On 1/29/21 12:18 PM, Jakub Kicinski wrote:
> > > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote:
> > >> The code does not care about the size of data -- All it does is t
On 1/29/2021 1:04 PM, Willem de Bruijn wrote:
> On Fri, Jan 29, 2021 at 4:01 PM Willem de Bruijn
> wrote:
>>
>> On Thu, Jan 28, 2021 at 7:46 PM Tony Nguyen
>> wrote:
>>>
>>> From: Jacob Keller
>>>
>>> The ice flash contains two copies of each of the NVM, Option ROM, and
>>> Netlist modules.
Vladimir Oltean writes:
> On Fri, Jan 22, 2021 at 02:44:51PM -0800, Vinicius Costa Gomes wrote:
>> The tc subsystem sets which queues are marked as preemptible, it's the
>> role of ethtool to control more hardware specific parameters. These
>> parameters include:
>>
>> - enabling the frame pree
On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote:
> On 1/29/21 12:18 PM, Jakub Kicinski wrote:
> > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote:
> >> The code does not care about the size of data -- All it does is that if
> >> MSG_OOB is set it will deliver the signal to the peer proces
Vladimir Oltean writes:
> On Fri, Jan 22, 2021 at 02:44:47PM -0800, Vinicius Costa Gomes wrote:
>> +/* It's valid to enable frame preemption without any kind of
>> + * offloading being enabled, so keep it separated.
>> + */
>> +if (tb[TCA_TAPRIO_ATTR_PREEMPT_TCS]) {
>> +
On Fri, Jan 29, 2021 at 4:01 PM Willem de Bruijn
wrote:
>
> On Thu, Jan 28, 2021 at 7:46 PM Tony Nguyen
> wrote:
> >
> > From: Jacob Keller
> >
> > The ice flash contains two copies of each of the NVM, Option ROM, and
> > Netlist modules. Each bank has a pointer word and a size word. In order
>
Hi,
Vladimir Oltean writes:
> On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote:
>> Avoid possible TX Hangs caused by using long Qbv cycles. In some
>> cases, using long cycles (more than 1 second) can cause transmissions
>> to be blocked for that time. As the TX Hang timeout
On Thu, Jan 28, 2021 at 7:46 PM Tony Nguyen wrote:
>
> From: Jacob Keller
>
> The ice flash contains two copies of each of the NVM, Option ROM, and
> Netlist modules. Each bank has a pointer word and a size word. In order
> to correctly read from the active flash bank, the driver must calculate
>
On 1/29/21 12:44 PM, Shoaib Rao wrote:
On 1/29/21 12:18 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote:
On 1/29/21 12:02 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote:
Data was discarded because the flag was not supported, this
On 1/29/21 12:18 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote:
On 1/29/21 12:02 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote:
Data was discarded because the flag was not supported, this patch
changes that but does not support
On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote:
> On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
> > Instead of discussing it several days, maybe it's better to review
> > current patch, so that we can move forward :)
>
> It took you 4 revisions to post a patch which builds cleanly a
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.c
> b/drivers/net/ethernet/microchip/lan743x_main.c
> index f1f6eba4ace4..f485320e5784 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.c
> +++ b/drivers/net/ethernet/microchip/lan743x_main.c
> @@ -1957,11 +1957,11 @@ static int
On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
> Instead of discussing it several days, maybe it's better to review
> current patch, so that we can move forward :)
It took you 4 revisions to post a patch which builds cleanly and now
you want to hasten the review? My favorite kind of submissio
On Thu, Jan 28, 2021 at 09:45:41AM +0100, Mike Looijmans wrote:
> Hi Andrew,
>
> Response below...
Hi Mike
Everybody here knows that top posting is evil, we don't do it. We
expect the replay to be inline.
> > Hi Mike
> >
> > Did you look at the per PHY reset? mdiobus_register_gpiod() gets the
On Thu, Jan 28, 2021 at 4:45 PM Tony Nguyen wrote:
>
> From: Aleksandr Loktionov
>
> This reverts commit 2ad1274fa35ace5c6360762ba48d33b63da2396c
>
> VF queues were not brought up when PF was brought up after being
> downed if the VF driver disabled VFs queues during PF down.
> This could happen
The channel stop and suspend paths both call __gsi_channel_stop(),
which quiesces channel activity, disables NAPI, and (on other than
SDM845) stops the channel. Similarly, the start and resume paths
share __gsi_channel_start(), which starts the channel and re-enables
NAPI again.
Disabling NAPI sh
Create a new helper function that encapsulates issuing a set of
channel stop commands, retrying if appropriate, with a short delay
between attempts.
Signed-off-by: Alex Elder
---
drivers/net/ipa/gsi.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/drive
Disable the I/O completion interrupt on a channel *after* we
successfully stop it rather than before. This ensures a completion
occurring just before the channel is stopped triggers an interrupt.
Enable the interrupt *before* starting a channel rather than after,
to be symmetric. A stopped chann
No completion interrupts will occur while an endpoint is suspended,
or when a channel has been stopped for suspend. So there's no need
to disable the interrupt during suspend and re-enable it when
resuming.
We'll enable the interrupt when we first start the channel, and
disable it again only when
Transactions to send data for a network device can be allocated at
any time up until the point the TX queue is stopped. It is possible
for ipa_start_xmit() to be called in one context just before a
the transmit queue is stopped in another.
Update gsi_channel_trans_last() so that for TX channels t
Open-code gsi_channel_freeze() and gsi_channel_thaw() in all callers
and get rid of these two functions. This is part of reworking the
sequence of things done during channel suspend/resume and start/stop.
Signed-off-by: Alex Elder
---
drivers/net/ipa/gsi.c | 37 -
Move the calls to enable or disable IEOB interrupts out of
__gsi_channel_start() and __gsi_channel_stop() and into their
callers. This is a small step to make the next patch easier
to understand.
Signed-off-by: Alex Elder
---
drivers/net/ipa/gsi.c | 45 +++---
Create a new function that does most of the work of starting a
channel. What's different is that it takes a flag indicating
whether the channel should really be stopped or not. When doing a
"normal" channel start, the flag is true. Create another new
function __gsi_channel_stop() that behaves si
If an error occurs starting a channel, don't "thaw" it.
We should assume the channel remains in a non-started state.
Update the comment in gsi_channel_stop(); calls to this function are
no longer retried.
Signed-off-by: Alex Elder
---
drivers/net/ipa/gsi.c | 6 --
1 file changed, 4 insertio
A few weeks ago I suggested a change that added a flag to determine
whether NAPI should be re-enabled on a channel when we're done
polling. That change was questioned, and upon further investigation
I realized the IPA suspend path was "doing it wrong."
Currently (for newer hardware) the IPA drive
On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote:
> On 1/29/21 12:02 PM, Jakub Kicinski wrote:
> > On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote:
> >> Data was discarded because the flag was not supported, this patch
> >> changes that but does not support any urgent data.
> > When you
On 1/29/21 12:02 PM, Jakub Kicinski wrote:
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote:
SO_OOBINLINE does not control the delivery of signal, It controls how
OOB Byte is delivered. It may not be obvious but this change does not
deliver any Byte, just a signal. So, as long as sendmsg fl
From: Sven Van Asbroeck
The buffers in the lan743x driver's receive ring are always 9K,
even when the largest packet that can be received (the mtu) is
much smaller. This performs particularly badly on cpu archs
without dma cache snooping (such as ARM): each received packet
results in a 9K dma_{ma
On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote:
> On 1/29/21 8:35 PM, Jakub Kicinski wrote:
>
> > kdoc didn't complain, and as you say it's already a mess, plus it's
> > two screen-fulls of scrolling away...
> >
> > I think converting to inline kdoc of members would be an improvement,
> >
On 1/29/2021 2:18 PM, Colin Ian King wrote:
Hi,
Static analysis with Coverity has detected an issue with the following
commit:
commit 0aa128475d33d2d0095947eeab6b3e4d22dbd578
Author: Daniel Jurgens
Date: Fri Jan 22 23:13:53 2021 +0200
net/mlx5: Maintain separate page trees for ECPF
From: Sven Van Asbroeck
Simulate low-memory in lan743x_rx_trim_skb(): fail one allocation
in every 100.
Signed-off-by: Sven Van Asbroeck
---
Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git #
46eb3c108fe1
To: Bryan Whitehead
To: unglinuxdri...@microchip.com
To: "David
From: Sven Van Asbroeck
Signed-off-by: Sven Van Asbroeck
---
Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git #
46eb3c108fe1
To: Bryan Whitehead
To: unglinuxdri...@microchip.com
To: "David S. Miller"
To: Jakub Kicinski
Cc: Andrew Lunn
Cc: Alexey Denisov
Cc: Sergej B
From: Sven Van Asbroeck
Now that we can use rx ring buffers smaller than the mtu,
we allow users to change the mtu on the fly.
Tested as follows:
Tests with debug logging enabled (add #define DEBUG).
1. Set the chip mtu to 1500, generate lots of network traffic.
Stop all network traffic.
On 1/29/21 11:54 AM, Shoaib Rao wrote:
On 1/29/21 11:19 AM, Matthew Wilcox wrote:
On Fri, Jan 29, 2021 at 09:56:48AM -0800, Shoaib Rao wrote:
On 1/25/21 3:36 PM, Jakub Kicinski wrote:
On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote:
From: Rao Shoaib
TCP sockets allow SIG
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote:
> >> SO_OOBINLINE does not control the delivery of signal, It controls how
> >> OOB Byte is delivered. It may not be obvious but this change does not
> >> deliver any Byte, just a signal. So, as long as sendmsg flag contains
> >> MSG_OOB, signal
On 1/29/21 11:19 AM, Matthew Wilcox wrote:
On Fri, Jan 29, 2021 at 09:56:48AM -0800, Shoaib Rao wrote:
On 1/25/21 3:36 PM, Jakub Kicinski wrote:
On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote:
From: Rao Shoaib
TCP sockets allow SIGURG to be sent to the process holding the
From: Sven Van Asbroeck
Simulate low-memory in lan743x_rx_allocate_skb(): fail 10
allocations in a row in every 100.
Signed-off-by: Sven Van Asbroeck
---
Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git #
46eb3c108fe1
To: Bryan Whitehead
To: unglinuxdri...@microchip.co
1 - 100 of 148 matches
Mail list logo
