On Fri, Jan 22, 2021 at 02:44:45PM -0800, Vinicius Costa Gomes wrote: > This is still an RFC because two main reasons, I want to confirm that > this approach (per-queue settings via qdiscs, device settings via > ethtool) looks good, even though there aren't much more options left ;-)
I don't want to bother you too much, but a consequence of putting the per-priority settings into tc-taprio is that those will spill over into other qdiscs too that have nothing to do with TSN, for whomever will need frame preemption without time-aware scheduling (and there are reasons to want that). So could we see in the next version the frame preemption bits added to tc-mqprio as well? I just want to make sure that we run this by the tc maintainers and that the idea gets their informed consent before we end up in a position where frame preemption with time-aware scheduling is done in one way, but frame preemption without time-aware scheduling is done another way. You should not need to change anything related to TC_SETUP_PREEMPT in the igc driver, so it should be just code addition.
