On Fri, 29 Jan 2021 12:44:59 -0800 Saeed Mahameed wrote: > On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > > Instead of discussing it several days, maybe it's better to review > > > current patch, so that we can move forward :) > > > > It took you 4 revisions to post a patch which builds cleanly and now > > you want to hasten the review? My favorite kind of submission. > > > > The mlxsw core + spectrum drivers are 65 times the size of psample > > on my system. Why is the dependency a problem? > > > > What's going to make sure the module gets loaded when it's needed? > > The issue is with distros who ship modules independently.. having a > hard dependency will make it impossible for basic mlx5_core.ko users to > load the driver when psample is not installed/loaded. > > I prefer to have 0 dependency on external modules in a HW driver.
I see. Well such distros are clearly broken, right? You can't ship a module without its dependencies.
