Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-20 Thread Kurt Kanzenbach
On Mon Oct 19 2020, Christian Eggers wrote: > Convert the bindings document for Microchip KSZ Series Ethernet switches > from txt to yaml. A few comments/questions below. > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > b/Documentation/devicetree/bindings/net/dsa/mic

Re: arm64 build broken on linux next 20201021 - include/uapi/asm-generic/unistd.h:862:26: error: array index in initializer exceeds array bounds

2020-10-20 Thread Marek Szyprowski
Hi Naresh, On 21.10.2020 07:05, Naresh Kamboju wrote: > arm64 build broken while building linux next 20201021 tag. > > include/uapi/asm-generic/unistd.h:862:26: error: array index in > initializer exceeds array bounds > #define __NR_watch_mount 441 > ^ > > Reported-by: Na

[PATCH net v2] ibmvnic: fix ibmvnic_set_mac

2020-10-20 Thread Lijun Pan
Jakub Kicinski brought up a concern in ibmvnic_set_mac(). ibmvnic_set_mac() does this: ether_addr_copy(adapter->mac_addr, addr->sa_data); if (adapter->state != VNIC_PROBED) rc = __ibmvnic_set_mac(netdev, addr->sa_data); So if state == VNIC_PROBED, the user can assi

Re: arm64 build broken on linux next 20201021 - include/uapi/asm-generic/unistd.h:862:26: error: array index in initializer exceeds array bounds

2020-10-20 Thread Stephen Rothwell
Hi Naresh, On Wed, 21 Oct 2020 10:35:10 +0530 Naresh Kamboju wrote: > > arm64 build broken while building linux next 20201021 tag. > > include/uapi/asm-generic/unistd.h:862:26: error: array index in > initializer exceeds array bounds > #define __NR_watch_mount 441 Yeah, the __NR_syscalls in in

RE: [PATCH V4 0/6] can: flexcan: add stop mode support for i.MX8QM

2020-10-20 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2020年10月21日 13:25 > To: m...@pengutronix.de; robh...@kernel.org; shawn...@kernel.org; > s.ha...@pengutronix.de > Cc: ker...@pengutronix.de; dl-linux-imx ; Ying Liu > ; linux-...@vger.kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.

[PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-20 Thread Dinghao Liu
When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu --- drivers/net/can/vxcan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c index d6ba9426be4d..aefc5a61d239 100644

[PATCH V4 3/6] dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource

2020-10-20 Thread Joakim Zhang
For SoCs with SCU support, need setup stop mode via SCU firmware, so this property can help indicate a resource in SCU firmware. Signed-off-by: Joakim Zhang --- Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devic

[PATCH V4 2/6] dt-bindings: can: flexcan: fix fsl,clk-source property

2020-10-20 Thread Joakim Zhang
Correct fsl,clk-source example since flexcan driver uses "of_property_read_u8" to get this property. Fixes: 9d733992772d ("dt-bindings: can: flexcan: add PE clock source property to device tree") Signed-off-by: Joakim Zhang --- Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 +- 1

[PATCH V4 1/6] firmware: imx: always export SCU symbols

2020-10-20 Thread Joakim Zhang
From: Liu Ying Always export SCU symbols for both SCU SoCs and non-SCU SoCs to avoid build error. Signed-off-by: Liu Ying Signed-off-by: Peng Fan Signed-off-by: Joakim Zhang --- include/linux/firmware/imx/ipc.h | 15 +++ include/linux/firmware/imx/svc/misc.h | 23 +++

[PATCH V4 6/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-20 Thread Joakim Zhang
The System Controller Firmware (SCFW) is a low-level system function which runs on a dedicated Cortex-M core to provide power, clock, and resource management. It exists on some i.MX8 processors. e.g. i.MX8QM (QM, QP), and i.MX8QX (QXP, DX). SCU driver manages the IPC interface between host CPU and

[PATCH V4 0/6] can: flexcan: add stop mode support for i.MX8QM

2020-10-20 Thread Joakim Zhang
The first patch from Liu Ying aims to export SCU symbols for SoCs w/wo SCU, so that no need to check CONFIG_IMX_SCU in the specific driver. The following patches are flexcan fixes and add stop mode support for i.MX8QM. ChangeLogs: V3->V4: * can_idx->scu_idx. * return imx_scu_get_h

[PATCH V4 4/6] can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR

2020-10-20 Thread Joakim Zhang
This patch intends to rename FLEXCAN_QUIRK_SETUP_STOP_MODE quirk to FLEXCAN_QUIRK_SETUP_STOP_MODE_GRP for non-scu SoCs, coming patch will add quirk for scu SoCs. For non-scu SoCs, setup stop mode with GPR register. For scu SoCs, setup stop mode with SCU firmware. Signed-off-by: Joakim Zhang ---

[PATCH V4 5/6] dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN

2020-10-20 Thread Joakim Zhang
Add IMX_SC_R_CAN(x) macro for CAN. Suggested-by: Marc Kleine-Budde Signed-off-by: Joakim Zhang --- include/dt-bindings/firmware/imx/rsrc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h index 54278d5c1856..4

arm64 build broken on linux next 20201021 - include/uapi/asm-generic/unistd.h:862:26: error: array index in initializer exceeds array bounds

2020-10-20 Thread Naresh Kamboju
arm64 build broken while building linux next 20201021 tag. include/uapi/asm-generic/unistd.h:862:26: error: array index in initializer exceeds array bounds #define __NR_watch_mount 441 ^ Reported-by: Naresh Kamboju build error log on arm64: -

Re: [PATCH net] chelsio/chtls: Utilizing multiple rxq/txq to process requests

2020-10-20 Thread Vinay Kumar Yadav
On 10/21/2020 9:56 AM, Jakub Kicinski wrote: On Wed, 21 Oct 2020 01:13:06 +0530 Vinay Kumar Yadav wrote: patch adds a logic to utilize multiple queues to process requests. The queue selection logic uses a round-robin distribution technique using a counter. What's the Fixes tag for this one?

Re: [PATCH net] chelsio/chtls: Utilizing multiple rxq/txq to process requests

2020-10-20 Thread Jakub Kicinski
On Wed, 21 Oct 2020 01:13:06 +0530 Vinay Kumar Yadav wrote: > patch adds a logic to utilize multiple queues to process requests. > The queue selection logic uses a round-robin distribution technique > using a counter. What's the Fixes tag for this one?

Re: [PATCH net] sfc: move initialisation of efx->filter_sem to efx_init_struct()

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 15:35:08 +0100 Edward Cree wrote: > efx_probe_filters() has not been called yet when EF100 calls into > efx_mcdi_filter_table_probe(), for which it wants to take the > filter_sem. > > Fixes: a9dc3d5612ce ("sfc_ef100: RX filter table management and related > gubbins") > Signe

[PATCHv2 net 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2020-10-20 Thread Hangbin Liu
Based on RFC7112, Section 6: IANA has added the following "Type 4 - Parameter Problem" message to the "Internet Control Message Protocol version 6 (ICMPv6) Parameters" registry: CODE NAME/DESCRIPTION 3 IPv6 First Fragment has incomplete IPv6 Header Chain Signed-of

[PATCHv2 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-20 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCHv2 net 0/2] IPv6: reply ICMP error with fragment doesn't contain all headers

2020-10-20 Thread Hangbin Liu
When our Engineer run latest IPv6 Core Conformance test, test v6LC.1.3.6: First Fragment Doesn’t Contain All Headers[1] failed. The test purpose is to verify that the node(Linux for example) should properly process IPv6 packets that don’t include all the headers through the Upper-Layer header. Bas

Re: [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 20:28:25 -0600 David Ahern wrote: > On 10/20/20 5:43 AM, Alexander Ovechkin wrote: > > mpls_iptunnel is used only for mpls encapsuation, and if encaplusated > > packet is larger than MTU we need mpls_gso for segmentation. > > > > Signed-off-by: Alexander Ovechkin > > Acked-by:

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread Xin Long
On Wed, Oct 21, 2020 at 5:23 AM Marcelo Ricardo Leitner wrote: > > On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote: > > > On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner > > > wrote: > > > > > > On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote: > > >> On Tue, Oct 20, 20

Re: [PATCH net] net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 17:33:22 -0700 Cong Wang wrote: > On Tue, Oct 20, 2020 at 3:03 PM Davide Caratti wrote: > > > > the following command > > > > # tc action add action tunnel_key \ > > > set src_ip 2001:db8::1 dst_ip 2001:db8::2 id 10 erspan_opts 1:6789:0:0 > > > > generates the following s

Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 17:37:22 -0700 Cong Wang wrote: > On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault wrote: > > > > We need to jump to the "err_out_locked" label when > > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > > with ->tcfa_lock still held. > > > > Fixes: d29bdd69

Re: [PATCH] net: dsa: bcm_sf2: make const array static, makes object smaller

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 09:51:39 -0700 Florian Fainelli wrote: > On 10/20/20 9:50 AM, Colin King wrote: > > From: Colin Ian King > > > > Don't populate the const array rate_table on the stack but instead it > > static. Makes the object code smaller by 46 bytes. > > > > Before: > >textdat

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: > On 20/10/2020 09:38, Geert Uytterhoeven wrote: > > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may > > not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like > > is done for all other IPv6 features.

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-20 Thread Joel Stanley
On Wed, 21 Oct 2020 at 00:00, Benjamin Herrenschmidt wrote: > > On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > > We must ensure the tx descriptor updates are visible before updating > > the tx pointer. > > > > This resolves the tx hangs observed on the 2600 when running iperf: > > To cla

Re: [PATCH 1/1] powerpc/vnic: Extend "failover pending" window

2020-10-20 Thread Lijun Pan
> On Oct 20, 2020, at 10:14 PM, Sukadev Bhattiprolu > wrote: > > Commit 5a18e1e0c193b introduced the 'failover_pending' state to track > the "failover pending window" - where we wait for the partner to become > ready (after a transport event) before actually attempting to failover. > i.e wind

[PATCH 1/1] powerpc/vnic: Extend "failover pending" window

2020-10-20 Thread Sukadev Bhattiprolu
Commit 5a18e1e0c193b introduced the 'failover_pending' state to track the "failover pending window" - where we wait for the partner to become ready (after a transport event) before actually attempting to failover. i.e window is between following two events: a. we get a transport event due

Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-20 Thread Geliang Tang
Hi Jakub, Jakub Kicinski 于2020年10月21日周三 上午7:39写道: > > On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote: > > This patchset deals with initializations of mptcp_options_received's two > > fields, ahmac and port. > > Applied, but two extra comments: > - please make sure the commit messages are

Re: [EXT] Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

2020-10-20 Thread Greg Ungerer
Hi Andy, On 21/10/20 12:19 pm, Andy Duan wrote: From: Greg Ungerer Sent: Wednesday, October 21, 2020 9:52 AM Hi Andrew, Thanks for the quick response. On 20/10/20 12:40 pm, Andrew Lunn wrote: On Tue, Oct 20, 2020 at 12:14:04PM +1000, Greg Ungerer wrote: Hi Andrew, Commit f166f890c8f0 ("

Re: [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel

2020-10-20 Thread David Ahern
On 10/20/20 5:43 AM, Alexander Ovechkin wrote: > mpls_iptunnel is used only for mpls encapsuation, and if encaplusated > packet is larger than MTU we need mpls_gso for segmentation. > > Signed-off-by: Alexander Ovechkin > Acked-by: Dmitry Yakunin > --- > net/mpls/mpls_iptunnel.c | 1 + > 1 file

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Chris Packham
On 21/10/20 10:18 am, Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 09:06:32PM +, Chris Packham wrote: >> On 21/10/20 3:51 am, Marek Behun wrote: >>> On Tue, 20 Oct 2020 15:15:25 +0100 >>> Russell King - ARM Linux admin wrote: >>> On Tue, Oct 20, 2020 at 04:05:35PM +020

RE: [EXT] Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

2020-10-20 Thread Andy Duan
From: Greg Ungerer Sent: Wednesday, October 21, 2020 9:52 AM > Hi Andrew, > > Thanks for the quick response. > > > On 20/10/20 12:40 pm, Andrew Lunn wrote: > > On Tue, Oct 20, 2020 at 12:14:04PM +1000, Greg Ungerer wrote: > >> Hi Andrew, > >> > >> Commit f166f890c8f0 ("[PATCH] net: ethernet: f

[PATCH v3] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-20 Thread zhudi
From: Di Zhu "ip addr show" command execute error when we have a physical network card with a large number of VFs The return value of if_nlmsg_size() in rtnl_calcit() will exceed range of u16 data type when any network cards has a larger number of VFs. rtnl_vfinfo_size() will significant increas

Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

2020-10-20 Thread Greg Ungerer
Hi Andrew, Thanks for the quick response. On 20/10/20 12:40 pm, Andrew Lunn wrote: On Tue, Oct 20, 2020 at 12:14:04PM +1000, Greg Ungerer wrote: Hi Andrew, Commit f166f890c8f0 ("[PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO") breaks the FEC driver on at least one o

Re: [PATCH v2 1/1] powerpc/vnic: Extend "failover pending" window

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 12:52:33 -0700 Sukadev Bhattiprolu wrote: > From 67f8977f636e462a1cd1eadb28edd98ef4f2b756 Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu > Date: Thu, 10 Sep 2020 11:18:41 -0700 > Subject: [PATCH 1/1] powerpc/vnic: Extend "failover pending" window I think you copy/pasted

Re: [PATCH net 0/6] chelsio/chtls: Fix inline tls bugs

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 17:20:19 +0530 Vinay Kumar Yadav wrote: > This series of patches fix following bugs in chelsio inline tls driver. > > Patch1: Fix incorrect socket lock. > Patch2: correct netdevice for vlan interface. > Patch3: Fix panic when server is listening on ipv6. > Patch4: Fix panic whe

Re: [PATCH] net: chelsio: inline_crypto: fix Kconfig and build errors

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 11:10:59 -0700 Randy Dunlap wrote: > Fix build errors when TLS=m, TLS_TOE=y, and CRYPTO_DEV_CHELSIO_TLS=y. > > Having (tristate) CRYPTO_DEV_CHELSIO_TLS depend on (bool) TLS_TOE > is not strong enough to prevent the bad combination of TLS=m and > CRYPTO_DEV_CHELSIO_TLS=y, so add

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote: > On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote: > > > Completely crazy and outlandish idea, I know, but what's wrong with > > > doing this in DSA? > > > > I really do not have a problem with that approach however other

Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-20 Thread Cong Wang
On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault wrote: > > We need to jump to the "err_out_locked" label when > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > with ->tcfa_lock still held. > > Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading") > Signed-off-by

Re: [PATCH net] net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels

2020-10-20 Thread Cong Wang
On Tue, Oct 20, 2020 at 3:03 PM Davide Caratti wrote: > > the following command > > # tc action add action tunnel_key \ > > set src_ip 2001:db8::1 dst_ip 2001:db8::2 id 10 erspan_opts 1:6789:0:0 > > generates the following splat: ... > using IPv6 tunnels, act_tunnel_key allocates a fixed amount

Re: [PATCH v1 net-next 3/5] net: dsa: felix: add gate action offload based on tc flower

2020-10-20 Thread Vladimir Oltean
On Tue, Oct 20, 2020 at 03:23:19PM +0800, Xiaoliang Yang wrote: > VSC9959 supports Per-Stream Filtering and Policing(PSFP). Sream is > identified by Null Stream identification which is defined in > IEEE802.1Qci. > > For IEEE 802.1Qci, there are four tables need to set: stream table, > stream filte

[PATCH v3] net: phy: marvell: add special handling of Finisar modules with 88E1111

2020-10-20 Thread Robert Hancock
The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E PHY with a modified PHY ID. Add support for this ID using the 88E methods. By default these modules do not have 1000BaseX auto-negotiation enabled, which is not generally desirable with Linux networking drivers. Add handling

Re: [PATCH net] mpls: load mpls_gso after mpls_iptunnel

2020-10-20 Thread David Ahern
On 10/20/20 5:02 AM, Alexander Ovechkin wrote: > mpls_iptunnel is used only for mpls encapsuation, and if encaplusated > packet is larger than MTU we need mpls_gso for segmentation. Familiar with that problem > --- > net/mpls/mpls_iptunnel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [PATCH] nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 19:38:58 +0800 Defang Bo wrote: > check that the NFC_ATTR_FIRMWARE_NAME attributes are provided by the netlink > client prior to accessing them.This prevents potential unhandled NULL pointer > dereference exceptions which can be triggered by malicious user-mode > programs, if

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-20 Thread Benjamin Herrenschmidt
On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > We must ensure the tx descriptor updates are visible before updating > the tx pointer. > > This resolves the tx hangs observed on the 2600 when running iperf: To clarify the comment here. This doesn't ensure they are visible to the hardware

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 17:47:20 +0200 Matthieu Baerts wrote: > On 19/10/2020 13:32, Geert Uytterhoeven wrote: > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > > user may not want to enable. Fix this by making the test depend on > > MPTCP instead. > > Reviewed-by: Matthi

Re: [PATCH net] ibmvnic: no need to update adapter->mac_addr before it completes

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 18:28:12 -0500 Lijun Pan wrote: > @@ -1828,7 +1827,6 @@ static int ibmvnic_set_mac(struct net_device *netdev, > void *p) > int rc; > > rc = 0; > - ether_addr_copy(adapter->mac_addr, addr->sa_data); > if (adapter->state != VNIC_PROBED) > rc

Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote: > This patchset deals with initializations of mptcp_options_received's two > fields, ahmac and port. Applied, but two extra comments: - please make sure the commit messages are in imperative form e.g. "Initialize x..." rather than "This pa

Re: [PATCH v1 net-next 5/5] net: dsa: felix: add police action for tc flower offload

2020-10-20 Thread Vladimir Oltean
On Tue, Oct 20, 2020 at 03:23:21PM +0800, Xiaoliang Yang wrote: > This patch add police action to set flow meter table which is defined > in IEEE802.1Qci. Flow metering is two rates two buckets and three color > marker to policing the frames, we only enable one rate one bucket in > this patch. > >

[PATCH net] ibmvnic: no need to update adapter->mac_addr before it completes

2020-10-20 Thread Lijun Pan
Jakub Kicinski brought up a concern in ibmvnic_set_mac(). ibmvnic_set_mac() does this: ether_addr_copy(adapter->mac_addr, addr->sa_data); if (adapter->state != VNIC_PROBED) rc = __ibmvnic_set_mac(netdev, addr->sa_data); So if state == VNIC_PROBED, the user can assi

Re: [PATCH v1 net-next 2/5] net: mscc: ocelot: set vcap IS2 chain to goto PSFP chain

2020-10-20 Thread Vladimir Oltean
On Tue, Oct 20, 2020 at 03:23:18PM +0800, Xiaoliang Yang wrote: > VSC9959 supports Per-Stream Filtering and Policing(PSFP), which is > processing after VCAP blocks. We set this block on chain 3 and > set vcap IS2 chain to goto PSFP chain if hardware support. > > An example set is: > > tc

Re: [PATCH v1 net-next 1/5] net: mscc: ocelot: add and export MAC table lookup operations

2020-10-20 Thread Vladimir Oltean
On Tue, Oct 20, 2020 at 03:23:17PM +0800, Xiaoliang Yang wrote: > Add ocelot_mact_lookup() function to retrieve the row and column at > which an FDB entry with the given {DMAC, VID} key is found. > > This function is needed in felix DSA driver, so export it. > > Signed-off-by: Vladimir Oltean >

Re: [PATCH net] net/sched: act_ct: Fix adding udp port mangle operation

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 12:02:44 +0300 Roi Dayan wrote: > Need to use the udp header type and not tcp. > > Fixes: 9c26ba9b1f45 ("net/sched: act_ct: Instantiate flow table entry > actions") > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey Applied, thanks!

Re: [PATCH net] netsec: ignore 'phy-mode' device property on ACPI systems

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 14:50:01 +0200 Andrew Lunn wrote: > On Sun, Oct 18, 2020 at 06:36:25PM +0200, Ard Biesheuvel wrote: > > Since commit bbc4d71d63549bc ("net: phy: realtek: fix rtl8211e rx/tx > > delay config"), the Realtek PHY driver will override any TX/RX delay > > set by hardware straps if the

Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 08:20:43 +0200 Vincent Bernat wrote: > ❦ 19 octobre 2020 17:53 -07, Jakub Kicinski: > > I'm not hearing any objections, but I have two questions: > > - do you intend to merge it for 5.10 or 5.11? Because it has a fixes > >tag, yet it's marked for net-next. If we put it in

Re: [PATCH net] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Lijun Pan
> On Oct 20, 2020, at 5:19 PM, Jakub Kicinski wrote: > > On Tue, 20 Oct 2020 17:07:38 -0500 Lijun Pan wrote: >>> Please read my reply carefully. >>> >>> What's the call path that leads to the address being wrong? If you set >>> the address via ifconfig it will call ibmvnic_set_mac() of the dr

[PATCH net v2] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Lijun Pan
After mac address change request completes successfully, the new mac address need to be saved to adapter->mac_addr as well as netdev->dev_addr. Otherwise, adapter->mac_addr still holds old data. Fixes: 62740e97881c ("net/ibmvnic: Update MAC address settings after adapter reset") Signed-off-by: Li

Re: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-20 Thread Andrew Jeffery
On Wed, 21 Oct 2020, at 08:40, Benjamin Herrenschmidt wrote: > On Tue, 2020-10-20 at 21:49 +0200, Arnd Bergmann wrote: > > On Tue, Oct 20, 2020 at 11:37 AM Dylan Hung > > wrote: > > > > +1 @first is system memory from dma_alloc_coherent(), right? > > > > > > > > You shouldn't have to do this.

Re: [PATCH bpf] bpf, doc: Fix patchwork URL to point to kernel.org instance

2020-10-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Tue, 20 Oct 2020 21:59:55 +0200 you wrote: > Follow-up on ebb034b15bfa ("bpf: Migrate from patchwork.ozlabs.org > to patchwork.kernel.org.") in order to fix up the patchwork URL (Q) > in the MAINTAINERS file for BPF subsystem. >

Re: [PATCH net] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 17:07:38 -0500 Lijun Pan wrote: > > Please read my reply carefully. > > > > What's the call path that leads to the address being wrong? If you set > > the address via ifconfig it will call ibmvnic_set_mac() of the driver. > > ibmvnic_set_mac() does the copy. > > > > But it doe

Re: [PATCH net] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Lijun Pan
> On Oct 20, 2020, at 5:07 PM, Lijun Pan wrote: > > > >> On Oct 20, 2020, at 4:33 PM, Jakub Kicinski wrote: >> >> On Tue, 20 Oct 2020 16:18:04 -0500 Lijun Pan wrote: On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote: On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote: >>

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread 'Marcelo Ricardo Leitner'
On Tue, Oct 20, 2020 at 10:08:17PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 20 October 2020 22:24 > ... > > > > Did FreeBSD enable it by default too? > > > No. The default is 0, which means that the encapsulation is turned off. > > > Setting this sysctl variable to a non

Re: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-20 Thread Benjamin Herrenschmidt
On Tue, 2020-10-20 at 21:49 +0200, Arnd Bergmann wrote: > On Tue, Oct 20, 2020 at 11:37 AM Dylan Hung wrote: > > > +1 @first is system memory from dma_alloc_coherent(), right? > > > > > > You shouldn't have to do this. Is coherent DMA memory broken on your > > > platform? > > > > It is about the

RE: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 20 October 2020 22:24 ... > > > Did FreeBSD enable it by default too? > > No. The default is 0, which means that the encapsulation is turned off. > > Setting this sysctl variable to a non-zero value enables the UDP tunneling > > with the given port. > > Thanks

Re: [PATCH net] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Lijun Pan
> On Oct 20, 2020, at 4:33 PM, Jakub Kicinski wrote: > > On Tue, 20 Oct 2020 16:18:04 -0500 Lijun Pan wrote: >>> On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote: >>> >>> On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote: After mac address change request completes successfully, the

[PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-20 Thread Joel Stanley
We must ensure the tx descriptor updates are visible before updating the tx pointer. This resolves the tx hangs observed on the 2600 when running iperf: root@ast2600:~# iperf3 -c 192.168.86.146 -R Connecting to host 192.168.86.146, port 5201 Reverse mode, remote host 192.168.86.146 is sending [

Re: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-20 Thread Benjamin Herrenschmidt
On Tue, 2020-10-20 at 13:15 +, David Laight wrote: > That rather depends where the data is 'stuck'. > > An old sparc cpu would flush the cpu store buffer before the read. > But a modern x86 cpu will satisfy the read from the store buffer > for cached data. > > If the write is 'posted' on a PC

[PATCH net] net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels

2020-10-20 Thread Davide Caratti
the following command # tc action add action tunnel_key \ > set src_ip 2001:db8::1 dst_ip 2001:db8::2 id 10 erspan_opts 1:6789:0:0 generates the following splat: BUG: KASAN: slab-out-of-bounds in tunnel_key_copy_opts+0xcc9/0x1010 [act_tunnel_key] Write of size 4 at addr 88813f5f1cc8 by

Re: [PATCH ethtool 0/4] add missing message descriptions

2020-10-20 Thread Jakub Kicinski
On Mon, 19 Oct 2020 23:32:37 +0200 (CEST) Michal Kubecek wrote: > Add message descriptions needed for pretty printing of netlink messages > related to recently added features: genetlink policy dumps and pause frame > statistics. First two patches extend pretty printing code with features > used by

Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 07:45:09 -0400 Michael S. Tsirkin wrote: > On Mon, Oct 19, 2020 at 12:15:00PM -0700, Jakub Kicinski wrote: > > On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote: > > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > > > When the device does not

Re: [PATCH net] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 16:18:04 -0500 Lijun Pan wrote: > > On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote: > > > > On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote: > >> After mac address change request completes successfully, the new mac > >> address need to be saved to adapter->mac_addr as

Re: [PATCH v3 3/3] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 09:24:04PM +, Chris Packham wrote: > > On 20/10/20 11:18 pm, Russell King - ARM Linux admin wrote: > > On Tue, Oct 20, 2020 at 04:45:58PM +1300, Chris Packham wrote: > >> +void mv88e6123_serdes_get_regs(struct mv88e6xxx_chip *chip, int port, > >> void *_p) > >> +{ > >>

[PATCH bpf v3 2/2] selftests: Update test_tc_redirect.sh to use the modified bpf_redirect_neigh()

2020-10-20 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This updates the test_tc_neigh prog in selftests to use the new syntax of bpf_redirect_neigh(). To exercise the helper both with and without the optional parameter, add an additional test_tc_neigh_fib test program, which does a bpf_fib_lookup() followed by a call to b

[PATCH bpf v3 0/2] bpf: Rework bpf_redirect_neigh() to allow supplying nexthop from caller

2020-10-20 Thread Toke Høiland-Jørgensen
Based on previous discussion[0], we determined that it would be beneficial to rework bpf_redirect_neigh() so the caller can supply the nexthop information (e.g., from a previous call to bpf_fib_lookup()). This way, the two helpers can be combined without incurring a second FIB lookup to find the ne

[PATCH bpf v3 1/2] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter

2020-10-20 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Based on the discussion in [0], update the bpf_redirect_neigh() helper to accept an optional parameter specifying the nexthop information. This makes it possible to combine bpf_fib_lookup() and bpf_redirect_neigh() without incurring a duplicate FIB lookup - since the

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread Marcelo Ricardo Leitner
On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote: > > On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner > > wrote: > > > > On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote: > >> On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner > >> wrote: > >>> > >>> On Mon, Oct 1

Re: [PATCH net-next v5 0/4] GVE Raw Addressing

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 11:12:48 -0700 David Awogbemila wrote: > Changes from v4: > Patch 2: Remove "#include " gve_rx.c - it was added > by accident. We have already sent a pull request for 5.10 and therefore net-next is closed for new drivers, features, and code refactoring. Please repost wh

Re: [PATCH v3 3/3] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-20 Thread Chris Packham
On 20/10/20 11:18 pm, Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 04:45:58PM +1300, Chris Packham wrote: >> +void mv88e6123_serdes_get_regs(struct mv88e6xxx_chip *chip, int port, void >> *_p) >> +{ >> +u16 *p = _p; >> +u16 reg; >> +int i; >> + >> +if (mv88e6xxx

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 09:06:32PM +, Chris Packham wrote: > > On 21/10/20 3:51 am, Marek Behun wrote: > > On Tue, 20 Oct 2020 15:15:25 +0100 > > Russell King - ARM Linux admin wrote: > > > >> On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: > >>> On Tue, Oct 20, 2020 at 03:49:40P

Re: [PATCH net] ibmvnic: save changed mac address to adapter->mac_addr

2020-10-20 Thread Lijun Pan
> On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote: >> After mac address change request completes successfully, the new mac >> address need to be saved to adapter->mac_addr as well as >> netdev->dev_addr. Otherwise, adapter->mac_addr sti

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Andrew Lunn
Hi Chris > So far I've not needed to use interrupts from the 6097. It's connected > on my hardware but never been tested. The mv88e6xxx driver will also poll the interrupt bits, if the interrupt is not wired to a GPIO. > There are a couple of SERDES LinkInt bits in the Global2 interrupt > sourc

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread Michael Tuexen
> On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner > wrote: > > On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote: >> On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner >> wrote: >>> >>> On Mon, Oct 19, 2020 at 08:25:33PM +0800, Xin Long wrote: --- a/Documentation/networking

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-20 Thread Marcelo Ricardo Leitner
On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote: > On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner > wrote: > > > > On Mon, Oct 19, 2020 at 08:25:33PM +0800, Xin Long wrote: > > > --- a/Documentation/networking/ip-sysctl.rst > > > +++ b/Documentation/networking/ip-sysctl.rst > > >

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Chris Packham
On 21/10/20 3:51 am, Marek Behun wrote: > On Tue, 20 Oct 2020 15:15:25 +0100 > Russell King - ARM Linux admin wrote: > >> On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: >>> On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: On Tue, 20 Oct 2020 11:15:52 +0100 Russ

Re: [PATCH RFC UEK5 2/7] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2020-10-20 Thread Konrad Rzeszutek Wilk
On Tue, Oct 20, 2020 at 04:59:59PM -0400, Konrad Rzeszutek Wilk wrote: > bpf_read() and bpf_read_str() could potentially be abused to (eg) allow > private keys in kernel memory to be leaked. Disable them if the kernel > has been locked down in confidentiality mode. > > Suggested-by: Alexei Starovo

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Chris Packham
On 21/10/20 3:58 am, Andrew Lunn wrote: >>> It's still there. The speed/duplex etc are read from the serdes PHY >>> via mv88e6390_serdes_pcs_get_state(). When the link comes up, we >>> pass the negotiated link parameters read from there to the link_up() >>> functions. For ports where mv88e6xxx_por

[PATCH RFC UEK5 2/7] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2020-10-20 Thread Konrad Rzeszutek Wilk
bpf_read() and bpf_read_str() could potentially be abused to (eg) allow private keys in kernel memory to be leaked. Disable them if the kernel has been locked down in confidentiality mode. Suggested-by: Alexei Starovoitov Signed-off-by: Matthew Garrett Reviewed-by: Kees Cook cc: netdev@vger.ker

Re: [PATCH iproute2-next 11/15] lib: Extract from iplink_vlan a helper to parse key:value arrays

2020-10-20 Thread Petr Machata
Roman Mashak writes: > Petr Machata writes: > > > [...] > >> +static int parse_qos_mapping(__u32 key, char *value, void *data) >> +{ >> +struct nlmsghdr *n = data; >> +struct ifla_vlan_qos_mapping m = { >> +.from = key, >> +}; >> + >> +if (get_u32(&m.to, value, 0))

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-20 Thread Petr Machata
Jakub Kicinski writes: > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) >> +{ >> +print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "off"); >> +} > > I'd personally lean in the direction ethtool is tak

Re: [PATCH v2] net: phy: marvell: add special handling of Finisar modules with 88E1111

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 01:10:48PM -0600, Robert Hancock wrote: > The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E PHY > with a modified PHY ID. Add support for this ID using the 88E > methods. > > By default these modules do not have 1000BaseX auto-negotiation enabled, > w

Re: [PATCH v1 net-next 0/5] net: dsa: felix: psfp support on

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 15:23:16 +0800 Xiaoliang Yang wrote: > This patch series add gate and police action for tc flower offload to > support Per-Stream Filtering and Policing(PSFP), which is defined in > IEEE802.1Qci. > > There is also a TC flower offload to set up VCAPs on ocelot driver. > Because

[PATCH bpf] bpf, doc: Fix patchwork URL to point to kernel.org instance

2020-10-20 Thread Daniel Borkmann
Follow-up on ebb034b15bfa ("bpf: Migrate from patchwork.ozlabs.org to patchwork.kernel.org.") in order to fix up the patchwork URL (Q) in the MAINTAINERS file for BPF subsystem. While at it, also add the official website (W) entry. Signed-off-by: Daniel Borkmann --- MAINTAINERS | 3 ++- 1 file

Re: [PATCH bpf v2 1/3] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter

2020-10-20 Thread Daniel Borkmann
On 10/20/20 9:01 PM, Jakub Kicinski wrote: On Tue, 20 Oct 2020 20:08:18 +0200 Toke Høiland-Jørgensen wrote: Isn't this backward? The hole could be named in the internal structure. This is a bit of a gray area, but if you name this hole in uAPI and programs start referring to it you will never be

[PATCH net] chelsio/chtls: Utilizing multiple rxq/txq to process requests

2020-10-20 Thread Vinay Kumar Yadav
patch adds a logic to utilize multiple queues to process requests. The queue selection logic uses a round-robin distribution technique using a counter. Signed-off-by: Ayush Sawal Signed-off-by: Vinay Kumar Yadav --- drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h| 1 + drivers/net/

[PATCH v2] rt2x00: save survey for every channel visited

2020-10-20 Thread Марков Михаил Александрович
rt2800 only gives you survey for current channel. Survey-based ACS algorithms are failing to perform their job when working with rt2800. Make rt2800 save survey for every channel visited and be able to give away that information. There is a bug registered https://dev.archive.openwrt.org/ticket/1

[PATCH net] chelsio/chtls: fix tls record info to user

2020-10-20 Thread Vinay Kumar Yadav
tls record header is not getting updated correctly causing application to close the connection in between data copy. fixing it by finalizing current record whenever tls header received. Fixes: 17a7d24aa89d ("crypto: chtls - generic handling of data and hdr") Signed-off-by: Vinay Kumar Yadav ---

Re: [PATCH net-next v2 2/3] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY

2020-10-20 Thread Dan Murphy
Andrew On 10/20/20 2:07 PM, Andrew Lunn wrote: Humm. Are 1v and 2.4v advertised so it can be auto negotiated? Maybe a PHY tunable is not correct? Is this voltage selection actually more like pause and EEE? [Goes and looks at the datasheet] Register 0x20E, bit 13: 1 = Advertise that the 10BASE

[PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

2020-10-20 Thread Robert Hancock
The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper operation in 1000BaseX mode. It should be safe to ensure this bit is disabled in phylink_mii_c22_pcs_config in all cases. Signed-off-by: Robert Hancock --- drivers/net/phy/phylink.c | 3 ++- 1 file changed, 2 insertions(+),

  1   2   3   >