Re: [PATCH net] ibmvnic: no need to update adapter->mac_addr before it completes

[Jakub Kicinski]

On Tue, 20 Oct 2020 18:28:12 -0500 Lijun Pan wrote:
> @@ -1828,7 +1827,6 @@ static int ibmvnic_set_mac(struct net_device *netdev, 
> void *p)
>       int rc;
>  
>       rc = 0;
> -     ether_addr_copy(adapter->mac_addr, addr->sa_data);
>       if (adapter->state != VNIC_PROBED)
>               rc = __ibmvnic_set_mac(netdev, addr->sa_data);
>  

If we just do this, in case state == VNIC_PROBED ibmvnic_set_mac() will
do nothing - just return 0 without saving the user supplied MAC address.