On Tue, Oct 20, 2020 at 01:10:48PM -0600, Robert Hancock wrote: > The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E1111 PHY > with a modified PHY ID. Add support for this ID using the 88E1111 > methods. > > By default these modules do not have 1000BaseX auto-negotiation enabled, > which is not generally desirable with Linux networking drivers. Add > handling to enable 1000BaseX auto-negotiation when these modules are > used in 1000BaseX mode. Also, some special handling is required to ensure > that 1000BaseT auto-negotiation is enabled properly when desired. > > Based on existing handling in the AMD xgbe driver and the information in > the Finisar FAQ: > https://www.finisar.com/sites/default/files/resources/an-2036_1000base-t_sfp_faqreve1.pdf
Just one further point... > > Signed-off-by: Robert Hancock <robert.hanc...@calian.com> > --- > drivers/net/phy/marvell.c | 99 ++++++++++++++++++++++++++++++++++++- > include/linux/marvell_phy.h | 3 ++ > 2 files changed, 101 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c > index 5aec673a0120..49392d15035c 100644 > --- a/drivers/net/phy/marvell.c > +++ b/drivers/net/phy/marvell.c > @@ -80,8 +80,11 @@ > #define MII_M1111_HWCFG_MODE_FIBER_RGMII 0x3 > #define MII_M1111_HWCFG_MODE_SGMII_NO_CLK 0x4 > #define MII_M1111_HWCFG_MODE_RTBI 0x7 > +#define MII_M1111_HWCFG_MODE_COPPER_1000BX_AN 0x8 I would suggest using MII_M1111_HWCFG_MODE_COPPER_1000X_AN, as there is a 1000BASE-BX. > #define MII_M1111_HWCFG_MODE_COPPER_RTBI 0x9 > #define MII_M1111_HWCFG_MODE_COPPER_RGMII 0xb > +#define MII_M1111_HWCFG_MODE_COPPER_1000BX_NOAN 0xc Same here. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
