On Wed, 2016-08-03 at 11:51 +0900, Masashi Honma wrote:
> On 2016年08月02日 16:27, Johannes Berg wrote:
> > This explicitly configures *HT capability* though - that's even the
> > name of the parameter. If you enable HT40 in the capability, the
> > resulting BSS might still not actually *use* 40 MHz b
Heinrich Schuchardt writes:
> If sta == NULL, the changed line will not be reached.
> So no need to check that sta != NULL here.
>
> v2:
> fix typo
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Larry Finger
> ---
> drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
> 1 file changed
net_device->ndo_set_rx_headroom (introduced in
871b642adebe300be2e50aa5f65a418510f636ec) says
"Setting a negtaive value reset the rx headroom
to the default value".
It seems that the OVS implementation in
3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7 overlooked this and sets
dev->needed_headroom
From: Roopa Prabhu
Also initialize vlan_flags
Fixes: d82a49ce85f0 ("bridge: add json support for bridge vlan show")
Signed-off-by: Roopa Prabhu
---
bridge/vlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bridge/vlan.c b/bridge/vlan.c
index f262cc7..22f32a5 100644
Соберем для Вас по интернет базу данных
потенциальных клиентов для Вашего Бизнеса!
В базе будут все контактные данные необходимые
для массовой продажи Ваших товаров и услуг.
По Вашему запросу пришлем пример и подробную информацию.
Если интересно запросите подробности сейчас
Email: bawupecoda-3..
From: Satish Baddipadige
When the rx coalescing time is 0, interrupts
are not generated from the controller and rx path hangs.
To avoid this rx hang, updating the driver to not allow
rx coalescing time to be 0.
Signed-off-by: Satish Baddipadige
Signed-off-by: Siva Reddy Kallam
Signed-off-by: M
From: Siva Reddy Kallam
This patch remove the wrong substraction from info->data in
tg3_get_rxnfc function. Without this patch, the number of RSS
queues reported is less by one.
Reported-by: Michal Soltys
Signed-off-by: Siva Reddy Kallam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/b
1) Fix several cases of missing of_node_put() calls in various networking
drivers. From Peter Chen.
2) Don't try to remove unconfigured VLANs in qed driver, from Yuval Mintz.
3) Unbalanced locking in TIPC error handling, from Wei Yongjun.
4) Fix lockups in CPDMA driver, from Grygorii Strash
On August 2, 2016 9:22:53 PM MST, Ding Tianhong wrote:
>On 2016/8/3 10:41, Florian Fainelli wrote:
>> On August 2, 2016 6:21:52 PM MST, Ding Tianhong
> wrote:
>>> On 2016/8/3 0:42, Florian Fainelli wrote:
Le 02/08/2016 à 06:00, Ding Tianhong a écrit :
> The nic in my board use the phy dev
On 2016/8/3 10:41, Florian Fainelli wrote:
> On August 2, 2016 6:21:52 PM MST, Ding Tianhong
> wrote:
>> On 2016/8/3 0:42, Florian Fainelli wrote:
>>> Le 02/08/2016 à 06:00, Ding Tianhong a écrit :
The nic in my board use the phy dev from marvell, and
the system will load the marvell ph
From: Siva Reddy Kallam
First patch:
Diasllow rx coalescing time to be 0
Second patch:
Report the correct number of RSS queues through tg3_get_rxnfc
Satish Baddipadige (1):
tg3: Fix for diasllow rx coalescing time to be 0
Siva Reddy Kallam (1):
tg3: Report the correct numbe
On 7/29/16 12:21 PM, subas...@codeaurora.org wrote:
Please don't try to workaround a bug with a sysctl.
If we have a bug here, we should fix it. Choosing
between bug A and bug B with a sysctl is not what
we are doing ;)
Sure, this was just a quick hack.
Can you give an example of your use cas
On Tue, Aug 2, 2016 at 7:17 PM, Feng Gao wrote:
> Thanks Tom's detail explanation.
> It is my misinterpret because my mother language is not English.
>
No, the RFC is somewhat poorly worded with respect to setting the
version number. The fact that flag bit must be set to zero on
transmit, but can
Al Viro wrote:
>
> Which just might mean that we have *three* issues here -
> (1) buggered __copy_to_user_inatomic() (and friends) on some sparcs
> (2) your ssl-only corruption
> (3) Alan's x86_64 corruption on plain TCP read - no ssl *or* sparc
> anywhere, and no multi-segment r
Our Company Yokohama Rubber Company is interested in your services as
collection representative in your country, you will be on 10% commission for
all payment received on behalf of our company, if interested get back to me for
details Email: chen.kumik...@outlook.com
Thank you.
Chen Kumiko
On August 2, 2016 6:21:52 PM MST, Ding Tianhong wrote:
>On 2016/8/3 0:42, Florian Fainelli wrote:
>> Le 02/08/2016 à 06:00, Ding Tianhong a écrit :
>>> The nic in my board use the phy dev from marvell, and
>>> the system will load the marvell phy driver automatically,
>>> but when I remove the phy
On 2016年08月02日 16:27, Johannes Berg wrote:
This explicitly configures *HT capability* though - that's even the
name of the parameter. If you enable HT40 in the capability, the
resulting BSS might still not actually *use* 40 MHz bandwidth, as
required by overlapping BSS detection.
OK, I see.
HT
> Please try this patch, it makes it work for me again.
> I decided to extend the existing snat support in xt_socket.c instead
> of changing TPROXY target:
This fixes my example (with the DIVERT chain), but does not fix the two-line
example you gave below. Another setup I have is
Thanks Tom's detail explanation.
It is my misinterpret because my mother language is not English.
Thanks again:))
On Wed, Aug 3, 2016 at 9:59 AM, Tom Herbert wrote:
> On Tue, Aug 2, 2016 at 5:28 PM, Feng Gao wrote:
>> Hi Tom.
>>
>> I quote some description in RFC 2637.
>>
>> /**
On Tue, Aug 2, 2016 at 5:28 PM, Feng Gao wrote:
> Hi Tom.
>
> I quote some description in RFC 2637.
>
> /*/
>C
> (Bit 0) Checksum Present. Set to zero (0).
>
Note that the requirement is "*Set* to zero"; it is not must
On 2016/8/3 0:42, Florian Fainelli wrote:
> Le 02/08/2016 à 06:00, Ding Tianhong a écrit :
>> The nic in my board use the phy dev from marvell, and
>> the system will load the marvell phy driver automatically,
>> but when I remove the phy drivers, the system immediately panic:
>>
>> localhost login
In this case they both mean the same thing.
> On Aug 2, 2016, at 6:28 PM, Feng Gao wrote:
>
> Just a reminder, the version description is "contain 1", not "set 1".
>
> Best Regards
> Feng
signature.asc
Description: Message signed with OpenPGP using GPGMail
Hi Tom.
I quote some description in RFC 2637.
/*/
C
(Bit 0) Checksum Present. Set to zero (0).
R
(Bit 1) Routing Present. Set to zero (0).
K
(Bit 2) Key Present. Set to one (1).
S
(Bit 3)
On 7/6/16 12:23 PM, Simon Horman wrote:
Signed-off-by: Simon Horman
---
ip/link_iptnl.c | 12 +++-
ip/tunnel.c | 10 ++
man/man8/ip-link.8.in | 9 +
3 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/ip/link_iptnl.c b/ip/link_iptnl.c
index 8
On 08/03/2016 10:10 AM, kbuild test robot wrote:
[auto build test ERROR on net/master]
Sorry, typo. Thank you test robot
===
net_device->ndo_set_rx_headroom (introduced in
871b642adebe300be2e50aa5f65a418510f636ec) says
"Setting a negative value reset the rx headroom
to the default valu
Thanks Philp.
I get it, then i will send another update v3 patch soon.
On Wed, Aug 3, 2016 at 1:33 AM, Philp Prindeville
wrote:
> Inline...
>
>
> On 08/02/2016 12:10 AM, Feng Gao wrote:
>>
>> Thanks.
>> Because the original GRE uses the literal number directly, so I follow
>> this style.
>>
>> T
Hi Ian,
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Ian-Wienand/OVS-Ignore-negative-headroom-value/20160803-075826
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget
https://git.kernel.org/c
Hi,
net_device->ndo_set_rx_headroom (introduced in
871b642adebe300be2e50aa5f65a418510f636ec) says
"Setting a negative value reset the rx headroom
to the default value".
It seems that the OVS implementation in
3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7 overlooked this and sets
dev->needed_head
If net namespace is attached to a user namespace let's make container's
root owner of sysctls affecting said network namespace instead of global
root.
This also allows us to clean up net_ctl_permissions() because we do not
need to fudge permissions anymore for the container's owner since it now
ow
This patch simplifies how we update fsc and calculate vt from it - while
keeping the expected functionality identical with how hfsc behaves
curently. It also fixes a certain issue introduced with
a very old patch.
The idea is, that instead of correcting cl_vt before fsc curve update
(rtsc_min) and
The code using this variable has been commented out in the past as it
was causing issues in upperlimited link-sharing scenarios.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_h
Changes since v1:
- in the first patch's commit message, reference old patch using kernel.org's
historical tree (instead of using gmane)
- in the second patch we just remove variable
Notes regarding patch #1/2:
This patch syncs virtual times with fair service curve and fixes a very old
subtle
Are these revised patches still on their way?
John
On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote:
> Yuval,
> I will try to resubmit the patches this week with updated comments
>
> Thanks
> Vidya Sagar
>
> On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz
> wrote:
>
> >
On Thu, Jul 28, 2016 at 12:14 AM, wrote:
> From: Gao Feng
>
> The PPTP is encapsulated by GRE header with that GRE_VERSION bits
> must contain one. But current GRE RPS needs the GRE_VERSION must be
> zero. So RPS does not work for PPTP traffic.
>
> In my test environment, there are four MIPS cor
On 1 August 2016 at 19:36, Jarno Rajahalme wrote:
> ovs_ct_find_existing() issues a warning if an existing conntrack entry
> classified as IP_CT_NEW is found, with the premise that this should
> not happen. However, a newly confirmed, non-expected conntrack entry
> remains IP_CT_NEW as long as no
On 08/02/2016 05:12 PM, Jakub Kicinski wrote:
Using per-register incrementing ID can lead to
find_good_pkt_pointers() confusing registers which
have completely different values. Consider example:
0: (bf) r6 = r1
1: (61) r8 = *(u32 *)(r6 +76)
2: (61) r0 = *(u32 *)(r6 +80)
3: (bf) r7 = r8
4: (07)
On 08/02/2016 10:34 AM, arvind Yadav wrote:
>
>
> On Tuesday 02 August 2016 01:15 PM, Arnd Bergmann wrote:
>> On Monday, August 1, 2016 4:55:43 PM CEST Scott Wood wrote:
>>> On 08/01/2016 02:02 AM, Arnd Bergmann wrote:
> diff --git a/include/linux/err.h b/include/linux/err.h
> index 1e355
From: Gerard Garcia
v3:
* Avoid race condition when freeing timer.
v2:
* Use of ERR_PTR/PTR_ERR/IS_ERR
* Timer cleaned on device release.
* Do not process more packets on error.
Signed-off-by: Gerard Garcia
---
drivers/vhost/vsock.c | 52 +--
1
The stmmac driver does not take into account the processor may be big
endian when writing the DMA descriptors. This causes the ethernet
interface not to be initialised correctly when running a big-endian
kernel. Change the descriptors for DMA to use __le32 and ensure they are
suitably swapped befor
sun4i-emac has the ability to print a number of diagnostic messages using
dev_dbg depending on message level settings implemented using netif_msg_*
macros. But there's no way to actually enable them.
Add the ability to switch diagnostic messages on using either a module
parameter debug or ethtool
The EMAC EMAC_RX_IO_DATA_REG data register is dual-purpose: On one hand
it is used to move actual packet data off the wire. This will be in
wire-format and accepted as such by higher layers such as IP. Therefore
it is correctly read as-is (i.e. raw) using readsl.
On the other hand it provides meta
This list_del() for tc action is not needed actually,
because we only use this list to chain bulk operations,
therefore should not be carried for latter operations.
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
net/sched/act_api.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sched
If sta == NULL, the changed line will not be reached.
So no need to check that sta != NULL here.
v2:
fix typo
Signed-off-by: Heinrich Schuchardt
Acked-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
On Tue, Aug 02, 2016 at 08:07:11PM +0200, Jan Engelhardt wrote:
>
> On Tuesday 2016-08-02 14:17, Baole Ni wrote:
>
> >I find that the developers often just specified the numeric value
> >when calling a macro which is defined with a parameter for access permission.
> >As we know, these numeric val
On Tue, Aug 02, 2016 at 04:12:14PM +0100, Jakub Kicinski wrote:
> Using per-register incrementing ID can lead to
> find_good_pkt_pointers() confusing registers which
> have completely different values. Consider example:
>
> 0: (bf) r6 = r1
> 1: (61) r8 = *(u32 *)(r6 +76)
> 2: (61) r0 = *(u32 *)(r
On Mon, Aug 1, 2016 at 2:13 PM, Olof Johansson wrote:
>
> Hi,
>
> I came across this now when looking at merge conflicts when preparing
> this. I wish I had seen it sooner.
>
> On Thu, Jul 7, 2016 at 4:02 PM, Iyappan Subramanian
> wrote:
> > Added mdio node for mdio driver. Also added phy-handle
On Tuesday 2016-08-02 14:17, Baole Ni wrote:
>I find that the developers often just specified the numeric value
>when calling a macro which is defined with a parameter for access permission.
>As we know, these numeric value for access permission have had the
>corresponding macro,
>and that using
From: Pavel Machek
Date: Tue, 2 Aug 2016 19:47:33 +0200
> But that does not make me like the series. And yes, hiding backdoor
> in one of those would be way too easy...
This is one of the worst patch series submissions in history.
At vger.kernel.org postmaster I just spent 45 minutes dealing
wit
i is defined as int but output as %u several times.
Adjust the format identifiers.
v2:
Keep definition of i as int.
David indicated that this is the preferable way to define
loop variables.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/intel/i40e/i40e_ethto
After refactoring tc_action into tcf_common, we no
longer need to cleanup temporary "actions" in list,
they are permanently stored in the hashtable.
Reported-by: Jamal Hadi Salim
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
net/sched/act_api.c | 22 +++---
1 file changed,
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
Inline...
On 08/02/2016 12:10 AM, Feng Gao wrote:
Thanks.
Because the original GRE uses the literal number directly, so I follow
this style.
Then I have two questions.
1. pptp_gre_header is defined in "drivers/net/ppp/pptp.c"; If we want
to use it, need to create one new header file, is it ok
Dear Beneficiary
I am Peter Douglas Director Inspection Unit United Nations Inspection Agent in
Hartsfield–Jackson Atlanta International Airport Atlanta GA. We are rounding up
for the last Quater of the auditing, all abandom Consignment in US Airports are
being transfer to our facilities here f
Lino Sanfilippo wrote:
By looking closer to the code, the lock seems to serve the protection of a list
of skbs that
are queued to be timestamped. However there is nothing that ever enqueues those
skbs, is it?
I assume that this is a leftover of a previous version of that driver. Code to
be me
On Tue 2016-08-02 09:29:27, Eric W. Biederman wrote:
> Baole Ni writes:
>
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access
> > permission.
> > As we know, these numeric value for access permission have had
From: Gerard Garcia
This patch applies over VSOCK RFC v6.
Once the guest puts a packet in the virtqueue it is guaranteed
that it will be delivered.
This patch addresses the problem of packets being discarded when
there is not available memory in the host.
Gerard Garcia (1):
Add timer to hand
Yes, it's incorrect at other places as well.
That went in the very early stages of development and didn't change it because
that out of bounds issue will never happen as no of logical interfaces
will never be
morethan MAX_LMAC i.e 8, so max vf_id will be 7.
But with addition of support for newer
Le 02/08/2016 à 06:00, Ding Tianhong a écrit :
> The nic in my board use the phy dev from marvell, and
> the system will load the marvell phy driver automatically,
> but when I remove the phy drivers, the system immediately panic:
>
> localhost login: [ 2582.052465] Unable to handle kernel NULL po
Hi,
> Gesendet: Dienstag, 02. August 2016 um 12:38 Uhr
> Von: "Baole Ni"
> An: 3ch...@gmail.com, t...@kernel.org, l...@kernel.org, x...@kernel.org,
> h...@zytor.com
> Cc: linux-atm-gene...@lists.sourceforge.net, netdev@vger.kernel.org,
> linux-ker...@vger.kernel.org, chuansheng@intel.com, b
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
Baole Ni writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I don’t think macros is clearer, and the meaning of those so called
“magic numbers” like 0644 is clear enough. People are used to that.
As a result, it is not meaningful to replace them with macro.
> 在 2016年8月2日，19:46，Baole Ni 写道：
>
> I find that the developers often just specified the numeric
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
On Tuesday 02 August 2016 01:15 PM, Arnd Bergmann wrote:
On Monday, August 1, 2016 4:55:43 PM CEST Scott Wood wrote:
On 08/01/2016 02:02 AM, Arnd Bergmann wrote:
diff --git a/include/linux/err.h b/include/linux/err.h
index 1e35588..c2a2789 100644
--- a/include/linux/err.h
+++ b/include/linux/
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of
1 - 100 of 257 matches
Mail list logo
