I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> Signed-off-by: Baole Ni <baolex...@intel.com> --- drivers/net/netconsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 06ee639..c5e543e 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -61,7 +61,7 @@ module_param_string(netconsole, config, MAX_PARAM_LENGTH, 0); MODULE_PARM_DESC(netconsole, " netconsole=[src-port]@[src-ip]/[dev],[tgt-port]@<tgt-ip>/[tgt-macaddr]"); static bool oops_only = false; -module_param(oops_only, bool, 0600); +module_param(oops_only, bool, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(oops_only, "Only log oops messages"); #ifndef MODULE -- 2.9.2
